#192#193
Open
zweissman wants to merge 2 commits intoBelval:masterfrom
Open
Conversation
added 2 commits
March 24, 2021 15:54
Added command line script convert_from_path.py Updated ValueError message for Size not being a tuple or integer. It was missing the format part of the statement and added the actual type that is being passed.
…age. That has to be called before the rest of the local imports. Also, removing the code for uuid generator. the pdf2image code will handle the uuid generation if the user does not provide a output_file via the command line.
Owner
|
Sorry I am a bit slower to respond these days. I have been working too much. I like the idea of your PR and the code seems fine as well. I'll test it in the coming days and if it works it should be good to merge. |
|
Belval
force-pushed
the
master
branch
6 times, most recently
from
181771a to
3628b54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added command line script convert_from_path.py
Updated ValueError message for Size not being a tuple or integer. It was missing the format part of the statement and added the actual type that is being passed.