Extend decoration leak test to italic, underlined, strikethrough, obfuscated#2920
Merged
tastybento merged 1 commit intodevelopfrom Apr 7, 2026
Merged
Conversation
…cated The decoration leak fixed in the previous commit affected all five decorations equally, not just bold. Lock that in with a parameterised test that verifies each decoration in turn. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2918 — the bold leak fixed there affected all five Adventure decorations equally, not just bold. The reporter on #2917 confirmed the same issue with
<italic>,<underlined>,<strikethrough>, and<obfuscated>.The fix in #2918 already handled all five (the
EmittedStatewalker tracks every decoration and inserts§ron any on→off transition), but the test only locked in the bold case. This adds a parameterised round-trip test that exercises each decoration in turn so we don't regress.Refs #2917
Test plan
./gradlew test --tests world.bentobox.bentobox.util.LegacyToMiniMessageTest— 6 tests passcomponentToLegacyand passes against the new walker🤖 Generated with Claude Code