Skip to content

Remove redundant and misleading vanilla nether/end teleport tests #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tastybento merged 2 commits into from
Mar 8, 2026
Merged

Remove redundant and misleading vanilla nether/end teleport tests #167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c040ce3
Initial plan
Copilot Mar 8, 2026
7442947
Remove redundant testOnPlayerTeleportInVanillaNether and testOnPlayer…
Copilot Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions src/test/java/world/bentobox/border/listeners/PlayerListenerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,38 +252,6 @@ public void testOnPlayerTeleportInIslandEnd() {
mockedBukkit.verify(Bukkit::getScheduler);
}

/**
* Test method for {@link world.bentobox.border.listeners.PlayerListener#onPlayerTeleport(org.bukkit.event.player.PlayerTeleportEvent)}.
* Vanilla (non-island) nether - should return early without any border activity.
*/
@Test
public void testOnPlayerTeleportInVanillaNether() {
when(addon.inGameWorld(any())).thenReturn(true);
when(iwm.isIslandNether(any())).thenReturn(false); // vanilla nether, not island nether
when(iwm.isIslandEnd(any())).thenReturn(false);
PlayerTeleportEvent event = new PlayerTeleportEvent(player, from, to, TeleportCause.NETHER_PORTAL);
pl.onPlayerTeleport(event);
verify(show).hideBorder(user);
verify(show).clearUser(user);
mockedBukkit.verify(Bukkit::getScheduler);
}

/**
* Test method for {@link world.bentobox.border.listeners.PlayerListener#onPlayerTeleport(org.bukkit.event.player.PlayerTeleportEvent)}.
* Vanilla (non-island) end - should return early without any border activity.
*/
@Test
public void testOnPlayerTeleportInVanillaEnd() {
when(addon.inGameWorld(any())).thenReturn(true);
when(iwm.isIslandNether(any())).thenReturn(false);
when(iwm.isIslandEnd(any())).thenReturn(false); // vanilla end, not island end
PlayerTeleportEvent event = new PlayerTeleportEvent(player, from, to, TeleportCause.END_PORTAL);
pl.onPlayerTeleport(event);
verify(show).hideBorder(user);
verify(show).clearUser(user);
mockedBukkit.verify(Bukkit::getScheduler);
}

/**
* Test method for {@link world.bentobox.border.listeners.PlayerListener#onPlayerLeaveIsland(org.bukkit.event.player.PlayerMoveEvent)}.
*/
Expand Down
Loading