Add SIS Ignore by student ID feature#13
Merged
steve-sullivan merged 2 commits intomainfrom Apr 23, 2026
Merged
Conversation
|
|
||
| raw_users.each do |user| | ||
| next if ignored_user?(user, ignore_list) | ||
|
|
There was a problem hiding this comment.
I actually prefer it this way and find it clearer but I thought the "rubocop" preferred way is a one liner like.
writer.write(SIS::Student.new(user)) unless ignored_user?(user, ignore_list)
davezuckerman
left a comment
davezuckerman
left a comment
There was a problem hiding this comment.
Looks good. Just a few little a few little observations
davezuckerman
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.