dags: Refactor image description into util class#59
Draft
Conversation
We can reuse this code in many different ways by making it a fully parameterised class instead of embedded in the DAG. This also gives us a lot of flexibility in how we use it in the future. Ref: AP-670
This adds an `ImageDescriber` class that accepts a processed TIND record as input and outputs a description of an image contained in that record. Test coverage is 86%; this is because we are presently not testing the "downloaded image is too large" code path. Ref: AP-670
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an
ImageDescriberclass that accepts a processed TIND recordas input and outputs a description of an image contained in that record.
Test coverage is 86%; this is because we are presently not testing the
"downloaded image is too large" code path.
Ref: AP-670