Replaced Newtonsoft.Json with NLog JsonLayout and support NLog v6#7
Open
snakefoot wants to merge 1 commit into
Open
Replaced Newtonsoft.Json with NLog JsonLayout and support NLog v6#7snakefoot wants to merge 1 commit into
snakefoot wants to merge 1 commit into
Conversation
snakefoot
force-pushed
the
main
branch
2 times, most recently
from
2c56b7a to
30b2f02
Compare
Contributor
Author
|
@PetrHeinz Ready for review and merge. |
snakefoot
force-pushed
the
main
branch
26 times, most recently
from
d09cedb to
787dada
Compare
snakefoot
force-pushed
the
main
branch
19 times, most recently
from
a34c9bc to
d05a017
Compare
Member
|
Hi @snakefoot, thanks for drafting a PR to tackle the missing context properties support 🙌 I've added a review and testing into our roadmap. Unfortunately, for our .NET packages this includes quite a bit of manual effort before successfully merging and releasing, so thanks for your patience on this 🙏 |
Contributor
Author
|
Thank you for the update. Glad it has been put on the roadmap. |
snakefoot
force-pushed
the
main
branch
3 times, most recently
from
3e3e9ac to
8e85cbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5 (Support setting
IncludeScopeProperties = true)