Fix getRepoSnapshot tree SHA fallback and remove unconditional branch lookup#167
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Fix May 30, 2026
getRepoSnapshot tree SHA fallback and remove unconditional branch lookup
naheel0
approved these changes
May 31, 2026
Member
|
@copilot resolve the merge conflicts in this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses all unresolved comments in the linked review thread for PR #166. The reported issues were an invalid
tree_shafallback (using commit SHA) and an extragetBranchcall on the success path.Tree fetch flow simplified
git.getTreenow first usesrepoInfo.default_branchdirectly.repos.getBranchis no longer called on every successful repository snapshot request.Fallback now resolves a real tree SHA
branch.commit.commit.tree.sha.git.getCommit(commit_sha)and usescommit.tree.sha(instead of passing commit SHA togetTree).Failure semantics preserved