phys-activity #150
Open
phys-activity #150
+70
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated necessary PAA variables for energy_exp calculation for master survey cycles 2015-16 and 2017-18
updated PAY variables for energy_exp calculation for master survey cycles 2015-16 and 2017-18
updated energy_exp function to include master survey cycles from 2001-2014 and included new calculation for master files 2015-16/2017-18
included master survey cycles into energy_exp dependent variables
included master survey cycles into energy_exp dependent PAY variables
included master survey cycles into energy_exp variable
yulric
changed the base branch from
feature/v3.0.0-validation-infrastructure
to
pct-time-canada
yulric
requested changes
Nov 10, 2025
Contributor
yulric
left a comment
yulric
left a comment
There was a problem hiding this comment.
The suffixes used for the new database names are inconsistent. Some rows use _m while others use _i. Can you fix that?
Author
|
@yulric no worries I've gone in and changed these |
yulric
requested changes
Nov 20, 2025
Contributor
yulric
left a comment
yulric
left a comment
There was a problem hiding this comment.
I don't think you fixed all the suffixes or I'm misunderstanding what those suffixes mean. I'm still seeing inconsistencies in:
- The PACDEE variable in the variable details sheet
- The PAA_045 variable in the variables sheet
- The PAA_050 variable in the variables sheet
- The PAA_075 variable in the variables sheet
- The PAA_080 variable in the variables sheet
- The PAADVDYS variable in the variables sheet
- The PAADVVIG variable in the variables sheet
- The PAYDVADL variable in the variables sheet
- The PAYDVDYS variable in the variables sheet
- The PAYDVTOA variable in the variables sheet
Author
|
@yulric I may not have pushed the updated branch. All the required variable suffixes are _m on my end. I've re-pushed the branch so let's see if that updates them properly now. |
Contributor
|
@caitlink12 Weird, I'm still seeing |
yulric
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in variable_details included master survey cycles 2001-2014 into PACDEE
in variable_details included master survey cycles 2015-2016 and 2017-2018 into PAA_045, PAA_050, PAA_075, PAA_080, PAADVDYS, PAADVVIG, PAYDVTOA, PAYDVAL, PAYDVVIG, PAYDVDYS
in variable_details included master survey cycles 2015-2016 and 2017-2018 for energy_exp
in variables.csv included master survey cycles 2001-2014 for PACDEE and master survey cycles 2015-2016 and 2017-2018 for energy_exp, PAA_045, PAA_050, PAA_075, PAA_080, PAADVDYS, PAADVVIG, PAYDVTOA, PAYDVAL, PAYDVVIG, PAYDVDYS