Code refactor, fixed bugs and add Win64 func#305
Open
GermanAizek wants to merge 1 commit intoBinomialLLC:masterfrom
Open
Code refactor, fixed bugs and add Win64 func#305GermanAizek wants to merge 1 commit intoBinomialLLC:masterfrom
GermanAizek wants to merge 1 commit intoBinomialLLC:masterfrom
Conversation
Contributor
|
@WiredGermanAizek this isn't my project. I would suggest though that since you have a lot of changes, reviewing would be easier if they were broken into individual commits, and with a description as to why you'd make that change. Looking at your code, there's some C++ modernisation (use of As for the Win64 additions, doesn't it only make sense for larger files? And what are the bugs addressed? |
Contributor
|
Could you describe the reasoning behind these changes? I'm pretty conservative about taking PR's. The more focused they are, the better. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@richgel999, @cwoffenden review my changes. Thx.