Update to build with Node 24 #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace username package with native os.userInfo() The username package (v7.0.0) is ESM-only and depends on execa, which causes bundling issues with @yao-pkg/pkg when building the standalone executable. The execa dependency was not being included in the pkg snapshot filesystem, resulting in: Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'execa' Since username was only used to get the current user as a fallback when SUDO_USER is not set, replace it with Node's built-in os.userInfo().username which provides the same functionality without external dependencies. Preliminary (testing) support for 26.04LTS (Resolute). Only for use in development testing with daily builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace username package with native os.userInfo()
The username package (v7.0.0) is ESM-only and depends on execa, which causes bundling issues with @yao-pkg/pkg when building the standalone executable. The execa dependency was not being included in the pkg snapshot filesystem, resulting in:
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'execa'
Since username was only used to get the current user as a fallback when SUDO_USER is not set, replace it with Node's built-in os.userInfo().username which provides the same functionality without external dependencies.
Preliminary (testing) support for 26.04LTS (Resolute). Only for use in development testing with daily builds.