Skip to content

fix: lightning wallet generation codec fix #7890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parvbitgo067 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

fix: lightning wallet generation codec fix #7890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/express/src/typedRoutes/api/v2/generateWallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { BooleanFromString } from 'io-ts-types';
import { httpRoute, httpRequest, optional } from '@api-ts/io-ts-http';
import { BitgoExpressError } from '../../schemas/error';
import { UserKeychainCodec, BackupKeychainCodec, BitgoKeychainCodec } from '../../schemas/keychain';
import { multisigType, walletType } from '../../schemas/wallet';
import { multisigType, walletSubType, walletType } from '../../schemas/wallet';

/**
* Request body for wallet generation.
Expand All @@ -17,6 +17,8 @@ export const GenerateWalletBody = {
multisigType: optional(multisigType),
/** The type of wallet, defined by key management and signing protocols. 'hot' and 'cold' are both self-managed wallets. If absent, defaults to 'hot' */
type: optional(walletType),
/** The subType of the wallet */
subType: optional(walletSubType),
/** Passphrase to be used to encrypt the user key on the wallet */
passphrase: optional(t.string),
/** User provided public key */
Expand Down
2 changes: 2 additions & 0 deletions modules/express/src/typedRoutes/schemas/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ export const multisigType = t.union([t.literal('onchain'), t.literal('tss')]);

export const walletType = t.union([t.literal('cold'), t.literal('custodial'), t.literal('hot'), t.literal('trading')]);

export const walletSubType = t.union([t.literal('lightningCustody'), t.literal('lightningSelfCustody')]);

/**
* Wallet response data
* Comprehensive wallet information returned from wallet operations
Expand Down