Merged
Conversation
fixed due serial configuration
* Fixed vertical speed variable * added velocitybody to lib
* added first setup for simvarwatcher * added runbundle event logic * flipped simvar map * added simvar update logic * fixed warnings and removed unused code * made it possible to alter update rate * reset outputs when swapping bundles * allowed decimal input * fixed tests
There was a problem hiding this comment.
Copilot reviewed 38 out of 40 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- crates/connector/src-tauri/connector_library/library.properties: Language not supported
- crates/connector/src-tauri/src/events/outputs.json: Language not supported
Comments suppressed due to low confidence (3)
crates/connector/src-tauri/src/simconnect_mod/simconnect_handler.rs:591
- The change from 'latest_output.update_every' to 'output.update_every' may introduce unintended behavior if these variables differ. Please verify that 'output.update_every' provides the correct value for the update frequency.
latest_output.update_every,
crates/connector/src-tauri/src/events/action.rs:4
- [nitpick] Prefixing field names with an underscore suggests they are unused, which can be misleading if these fields are meant for external use. Consider renaming them without the underscore if they are intended to be part of the public API.
pub _id: u32,
crates/connector/serial/src/serial/serial_device.rs:92
- In the serial device write loop, if 'self.port.write' returns 0 bytes written, the loop may become infinite. Consider adding a condition to break out of the loop when no progress is made.
while !remaining_data.is_empty() {
| { | ||
| Ok(path) => path, | ||
| Err(e) => { | ||
| Err(_) => { |
There was a problem hiding this comment.
Discarding the error information by replacing 'Err(e)' with 'Err(_)' removes potentially useful details for debugging. Consider logging or preserving the error details to aid in troubleshooting.
Suggested change
| Err(_) => { | |
| Err(e) => { | |
| error!("Failed to resolve exe.xml resource path: {:?}", e); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change is in this PR
What's changed
Provide a description of the changes you've made and why you made them.
Related issue
If applicable provide the issue number.
Checklist before merging