Skip Deinit() when modules were never initialized

[RiSKeD]

--check-config and --dry-run (on failure) call cleanup() without having called initModules(), causing spurious Deinit log noise on every config validation. Track whether module init was attempted and only run Deinit if it was.

[RiSKeD]

Before change:

root@anti-monitor:~# /usr/local/bin/dutagent --check-config -c /etc/dutagent/hermes-config-invalid-test.yaml 
2026/02/27 15:08:13 Bad configuration: parsing YAML failed: command must have at most one main module
2026/02/27 15:08:13 GRACEFUL SHUTDOWN: De-init modules
2026/02/27 15:08:13 All modules de-initialized

Afterwards:

root@anti-monitor:~# /usr/local/bin/dutagent --check-config -c /etc/dutagent/hermes-config-invalid-test.yaml 
2026/02/27 15:08:13 Bad configuration: parsing YAML failed: command must have at most one main module

[Copilot]

Pull request overview

This PR fixes spurious Deinit log noise that occurs when --check-config or --dry-run (on failure) execute cleanup without having initialized modules. A boolean flag is introduced to track whether module initialization was attempted, ensuring Deinit() is only called when appropriate.

Changes:

• Added modulesInitialed field to track whether initModules() was called
• Modified cleanup() to only call Deinit() if modules were initialized
• Simplified cleanup logic by removing the nil check for devices

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jenstopp]

Wouldn't it be even more robust to save the "init happened" info with each module?

[RiSKeD]

Sure this could also be done. I don't favor any of the approaches. I can rewrite it that way too.