sdk: Fix two issues with the signer #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Signer.start()` was not creating the runtime, and spawning the thread, rather it was assuming it already had a runtime. Since the signer is isolated, we can just have it spawn its own thread and runtime. The API will use a shared runtime it can block on, but the signer needs to run independently in the background. The second issue was that the `Signer.node_id()` method was still stubbed out. Now it delegates to the gl-client Signer. Reported-By: <@lvaccaro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signer.start()was not creating the runtime, and spawning thethread, rather it was assuming it already had a runtime. Since the
signer is isolated, we can just have it spawn its own thread and
runtime. The API will use a shared runtime it can block on, but the
signer needs to run independently in the background.
The second issue was that the
Signer.node_id()method was stillstubbed out. Now it delegates to the gl-client Signer.
Reported-By: <@lvaccaro>