input: improve setting/property validation errors#697
Merged
jkloetzke merged 1 commit intoBobBuildTool:masterfrom Feb 10, 2026
Merged
input: improve setting/property validation errors#697jkloetzke merged 1 commit intoBobBuildTool:masterfrom
jkloetzke merged 1 commit intoBobBuildTool:masterfrom
Conversation
The validation of internal settings already produces proper schema exceptions if errors are found. We must not cat these exceptions but propagate them, though. Likewise, allow external plugins to throw schema.SchemaError exceptions. In case the validate() function returns false, throw the exception ourselves. Fixes BobBuildTool#696.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #697 +/- ##
=======================================
Coverage 89.25% 89.25%
=======================================
Files 50 50
Lines 16443 16446 +3
=======================================
+ Hits 14676 14679 +3
Misses 1767 1767 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validation of internal settings already produces proper schema exceptions if errors are found. We must not cat these exceptions but propagate them, though.
Likewise, allow external plugins to throw schema.SchemaError exceptions. In case the validate() function returns false, throw the exception ourselves.
Fixes #696.