Skip to content

fix: rename ApplePayButtonComponentView to BoltApplePayButtonComponentView#40

Merged
arstiefel merged 1 commit intomainfrom
fix-rename
Mar 26, 2026
Merged

fix: rename ApplePayButtonComponentView to BoltApplePayButtonComponentView#40
arstiefel merged 1 commit intomainfrom
fix-rename

Conversation

@arstiefel
Copy link
Copy Markdown
Collaborator

@arstiefel arstiefel commented Mar 26, 2026

Description

Renames the iOS Fabric component view class from ApplePayButtonComponentView to BoltApplePayButtonComponentView so the ObjC class name matches the componentProvider value in codegenConfig. This ensures RCTThirdPartyComponentsProvider resolves the correct class via NSClassFromString at runtime, preventing an "unimplemented component" failure when the class name and provider entry diverge.

Testing

  • Run pod install in the example app's ios/ directory and verify RCTThirdPartyComponentsProvider.mm contains @"BoltApplePayButton": NSClassFromString(@"BoltApplePayButtonComponentView").
  • Run yarn example ios and confirm the Apple Pay button renders without an "unimplemented component" error.
  • Existing unit tests (yarn test) should continue to pass unchanged.

Security Review

Important

A security review is required for every PR in this repository to comply with PCI requirements.

  • I have considered and reviewed security implications of this PR and included the summary below.

Security Impact Summary

No security-sensitive changes. This PR only renames an internal Objective-C class for consistency with the codegen registration. It does not touch authentication, authorization, payment flows, user data handling, or external integrations.

@arstiefel arstiefel requested review from a team as code owners March 26, 2026 16:39
@snyk-io
Copy link
Copy Markdown

snyk-io bot commented Mar 26, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@arstiefel arstiefel merged commit 0954f65 into main Mar 26, 2026
8 of 9 checks passed
@arstiefel arstiefel deleted the fix-rename branch March 26, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants