fix: rename ApplePayButtonComponentView to BoltApplePayButtonComponentView#40
Merged
fix: rename ApplePayButtonComponentView to BoltApplePayButtonComponentView#40
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
isalazarbolt
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames the iOS Fabric component view class from
ApplePayButtonComponentViewtoBoltApplePayButtonComponentViewso the ObjC class name matches thecomponentProvidervalue incodegenConfig. This ensuresRCTThirdPartyComponentsProviderresolves the correct class viaNSClassFromStringat runtime, preventing an "unimplemented component" failure when the class name and provider entry diverge.Testing
pod installin the example app'sios/directory and verifyRCTThirdPartyComponentsProvider.mmcontains@"BoltApplePayButton": NSClassFromString(@"BoltApplePayButtonComponentView").yarn example iosand confirm the Apple Pay button renders without an "unimplemented component" error.yarn test) should continue to pass unchanged.Security Review
Important
A security review is required for every PR in this repository to comply with PCI requirements.
Security Impact Summary
No security-sensitive changes. This PR only renames an internal Objective-C class for consistency with the codegen registration. It does not touch authentication, authorization, payment flows, user data handling, or external integrations.