Fixed 5 failing tests due to list(set(... operations in ParseResults.__init__ #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as they destory the ordering of urls, users etc in the tweet. The list(set( operation on replies was dangerous as reply was a string not a list (so the string was split into a list of set elements of characters). Removed lots of non-pep8 whitespace
https://github.com/schwa/twitter-text-python/commit/b81cef33a6fc12c837936d60a0b4a86222d45a4f to add option to extract span for matched parts of message for URLs, users etc
…l text for the span=True tests
…ter e.g. space exists
…ollower in utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5 of the unit tests were failing for me, they were all caused by the list(set(... operations which destroyed ordering in ParseResults.init, also the list(set(... operation on @reply was destructive as the reply was a string not a list of strings (so you got an unordered set of characters). These are fixed in my fork, this is my first ever pull request, I hope I get the process right.
I've also removed lots of non-pep8 whitespace in tests.py and ttp.py.