Open
Conversation
UWEMAKAN
requested review from
MuhammadGb,
Neyodhino,
UWEMAKAN and
Umoren
and removed request for
Neyodhino
Thonze
previously approved these changes
May 14, 2020
MuhammadGb
previously approved these changes
May 14, 2020
UWEMAKAN
reviewed
May 14, 2020
| "node-sass": "4.14.1", | ||
| "react": "^16.13.1", | ||
| "react-dom": "^16.13.1", | ||
| "react-scripts": "3.4.1" |
Collaborator
There was a problem hiding this comment.
I'd love to know why you removed react-scripts
Author
There was a problem hiding this comment.
I didn't realize react script was removed, I simply ran npm install
UWEMAKAN
requested changes
May 14, 2020
Collaborator
UWEMAKAN
left a comment
UWEMAKAN
left a comment
There was a problem hiding this comment.
Tests are mandatory. Please, write tests for your code.
I tested the build on my phone and it would look better if the inputs were aligned properly and the font sizes are the same as what's on the wireframe.
…t page, contact page, footer and navbar components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guys,
I made some changes like -> i installed react-router-dom, redux, react-redux, redux-thunk, font-awesome library, axios and i also finished the login and signup pages.