Skip to content

Safe implementations of write_uint and write_uint128#202

Open
fintelia wants to merge 1 commit intoBurntSushi:masterfrom
fintelia:safe-write-uint
Open

Safe implementations of write_uint and write_uint128#202
fintelia wants to merge 1 commit intoBurntSushi:masterfrom
fintelia:safe-write-uint

Conversation

@fintelia
Copy link
Copy Markdown
Contributor

@fintelia fintelia commented Feb 18, 2024

No description provided.

@BurntSushi
Copy link
Copy Markdown
Owner

BurntSushi commented Apr 2, 2024

I think this probably LGTM, but the benchmarks should be compared before/after. Do you want to do that?

@fintelia
Copy link
Copy Markdown
Contributor Author

fintelia commented Apr 2, 2024

Added some benchmarks in #206. I didn't compare super closely, but the performance seemed to be in the same range.

@BurntSushi
Copy link
Copy Markdown
Owner

BurntSushi commented Apr 2, 2024

Can you share the benchmark results when you get a chance? Thanks.

@fintelia
Copy link
Copy Markdown
Contributor Author

fintelia commented Apr 3, 2024 •
edited
Loading

Here's the results if the byte count isn't hard-coded (by using bb($bytes) in the benchmarks).

On the master branch:

test uint_1::write_big_endian        ... bench:     107,573 ns/iter (+/- 68)
test uint_1::write_little_endian     ... bench:     107,575 ns/iter (+/- 181)
test uint_1::write_native_endian     ... bench:     107,611 ns/iter (+/- 456)
test uint_2::write_big_endian        ... bench:     279,904 ns/iter (+/- 1,708)
test uint_2::write_little_endian     ... bench:     280,058 ns/iter (+/- 1,403)
test uint_2::write_native_endian     ... bench:     279,756 ns/iter (+/- 586)
test uint_3::write_big_endian        ... bench:     279,714 ns/iter (+/- 2,018)
test uint_3::write_little_endian     ... bench:     279,711 ns/iter (+/- 637)
test uint_3::write_native_endian     ... bench:     279,710 ns/iter (+/- 312)
test uint_4::write_big_endian        ... bench:     258,275 ns/iter (+/- 488)
test uint_4::write_little_endian     ... bench:     258,324 ns/iter (+/- 3,371)
test uint_4::write_native_endian     ... bench:     258,272 ns/iter (+/- 954)
test uint_5::write_big_endian        ... bench:     258,216 ns/iter (+/- 745)
test uint_5::write_little_endian     ... bench:     258,348 ns/iter (+/- 664)
test uint_5::write_native_endian     ... bench:     258,290 ns/iter (+/- 657)
test uint_6::write_big_endian        ... bench:     258,355 ns/iter (+/- 2,584)
test uint_6::write_little_endian     ... bench:     258,248 ns/iter (+/- 1,417)
test uint_6::write_native_endian     ... bench:     258,294 ns/iter (+/- 4,444)
test uint_7::write_big_endian        ... bench:     258,247 ns/iter (+/- 12,597)
test uint_7::write_little_endian     ... bench:     258,232 ns/iter (+/- 1,128)
test uint_7::write_native_endian     ... bench:     258,219 ns/iter (+/- 27,794)
test uint_8::write_big_endian        ... bench:     236,703 ns/iter (+/- 569)
test uint_8::write_little_endian     ... bench:     236,704 ns/iter (+/- 45,750)
test uint_8::write_native_endian     ... bench:     236,678 ns/iter (+/- 307)

test uint128_10::write_big_endian    ... bench:     430,569 ns/iter (+/- 1,971)
test uint128_10::write_little_endian ... bench:     430,354 ns/iter (+/- 699)
test uint128_10::write_native_endian ... bench:     430,351 ns/iter (+/- 329)
test uint128_11::write_big_endian    ... bench:     430,341 ns/iter (+/- 275)
test uint128_11::write_little_endian ... bench:     430,371 ns/iter (+/- 565)
test uint128_11::write_native_endian ... bench:     430,364 ns/iter (+/- 315)
test uint128_12::write_big_endian    ... bench:     430,338 ns/iter (+/- 636)
test uint128_12::write_little_endian ... bench:     430,527 ns/iter (+/- 540)
test uint128_12::write_native_endian ... bench:     430,344 ns/iter (+/- 248)
test uint128_13::write_big_endian    ... bench:     430,347 ns/iter (+/- 252)
test uint128_13::write_little_endian ... bench:     430,378 ns/iter (+/- 126)
test uint128_13::write_native_endian ... bench:     430,560 ns/iter (+/- 622)
test uint128_14::write_big_endian    ... bench:     430,341 ns/iter (+/- 131)
test uint128_14::write_little_endian ... bench:     430,361 ns/iter (+/- 350)
test uint128_14::write_native_endian ... bench:     430,341 ns/iter (+/- 234)
test uint128_15::write_big_endian    ... bench:     430,335 ns/iter (+/- 236)
test uint128_15::write_little_endian ... bench:     430,362 ns/iter (+/- 252)
test uint128_15::write_native_endian ... bench:     430,359 ns/iter (+/- 279)
test uint128_16::write_big_endian    ... bench:     473,404 ns/iter (+/- 373)
test uint128_16::write_little_endian ... bench:     473,361 ns/iter (+/- 308)
test uint128_16::write_native_endian ... bench:     473,344 ns/iter (+/- 249)
test uint128_1::write_big_endian     ... bench:     107,634 ns/iter (+/- 674)
test uint128_1::write_little_endian  ... bench:     107,630 ns/iter (+/- 736)
test uint128_1::write_native_endian  ... bench:     107,653 ns/iter (+/- 784)
test uint128_2::write_big_endian     ... bench:     279,754 ns/iter (+/- 232)
test uint128_2::write_little_endian  ... bench:     279,787 ns/iter (+/- 300)
test uint128_2::write_native_endian  ... bench:     279,791 ns/iter (+/- 286)
test uint128_3::write_big_endian     ... bench:     236,958 ns/iter (+/- 1,755)
test uint128_3::write_little_endian  ... bench:     279,802 ns/iter (+/- 1,714)
test uint128_3::write_native_endian  ... bench:     279,804 ns/iter (+/- 1,639)
test uint128_4::write_big_endian     ... bench:     258,312 ns/iter (+/- 1,734)
test uint128_4::write_little_endian  ... bench:     258,325 ns/iter (+/- 2,255)
test uint128_4::write_native_endian  ... bench:     258,324 ns/iter (+/- 2,223)
test uint128_5::write_big_endian     ... bench:     258,308 ns/iter (+/- 998)
test uint128_5::write_little_endian  ... bench:     258,306 ns/iter (+/- 951)
test uint128_5::write_native_endian  ... bench:     258,299 ns/iter (+/- 1,022)
test uint128_6::write_big_endian     ... bench:     279,808 ns/iter (+/- 1,103)
test uint128_6::write_little_endian  ... bench:     258,569 ns/iter (+/- 508)
test uint128_6::write_native_endian  ... bench:     258,438 ns/iter (+/- 266)
test uint128_7::write_big_endian     ... bench:     258,644 ns/iter (+/- 1,030)
test uint128_7::write_little_endian  ... bench:     258,492 ns/iter (+/- 3,014)
test uint128_7::write_native_endian  ... bench:     258,459 ns/iter (+/- 3,799)
test uint128_8::write_big_endian     ... bench:     236,789 ns/iter (+/- 927)
test uint128_8::write_little_endian  ... bench:     236,786 ns/iter (+/- 832)
test uint128_8::write_native_endian  ... bench:     236,726 ns/iter (+/- 1,142)
test uint128_9::write_big_endian     ... bench:     430,485 ns/iter (+/- 1,541)
test uint128_9::write_little_endian  ... bench:     430,462 ns/iter (+/- 162)
test uint128_9::write_native_endian  ... bench:     430,425 ns/iter (+/- 859)

With this PR:

test uint_1::write_big_endian        ... bench:      21,518 ns/iter (+/- 47)
test uint_1::write_little_endian     ... bench:      21,518 ns/iter (+/- 14)
test uint_1::write_native_endian     ... bench:      21,517 ns/iter (+/- 11)
test uint_2::write_big_endian        ... bench:      21,523 ns/iter (+/- 43)
test uint_2::write_little_endian     ... bench:      21,518 ns/iter (+/- 18)
test uint_2::write_native_endian     ... bench:      21,518 ns/iter (+/- 11)
test uint_3::write_big_endian        ... bench:      21,518 ns/iter (+/- 36)
test uint_3::write_little_endian     ... bench:      21,520 ns/iter (+/- 135)
test uint_3::write_native_endian     ... bench:      21,518 ns/iter (+/- 51)
test uint_4::write_big_endian        ... bench:      21,518 ns/iter (+/- 13)
test uint_4::write_little_endian     ... bench:      21,518 ns/iter (+/- 13)
test uint_4::write_native_endian     ... bench:      21,519 ns/iter (+/- 177)
test uint_5::write_big_endian        ... bench:      21,518 ns/iter (+/- 15)
test uint_5::write_little_endian     ... bench:      21,519 ns/iter (+/- 19)
test uint_5::write_native_endian     ... bench:      21,518 ns/iter (+/- 12)
test uint_6::write_big_endian        ... bench:      21,518 ns/iter (+/- 12)
test uint_6::write_little_endian     ... bench:      21,518 ns/iter (+/- 13)
test uint_6::write_native_endian     ... bench:      21,518 ns/iter (+/- 14)
test uint_7::write_big_endian        ... bench:      21,518 ns/iter (+/- 13)
test uint_7::write_little_endian     ... bench:      21,518 ns/iter (+/- 19)
test uint_7::write_native_endian     ... bench:      21,518 ns/iter (+/- 12)
test uint_8::write_big_endian        ... bench:      21,518 ns/iter (+/- 12)
test uint_8::write_little_endian     ... bench:      21,518 ns/iter (+/- 12)
test uint_8::write_native_endian     ... bench:      21,518 ns/iter (+/- 22)

test uint128_10::write_big_endian    ... bench:     430,514 ns/iter (+/- 923)
test uint128_10::write_little_endian ... bench:     430,494 ns/iter (+/- 1,451)
test uint128_10::write_native_endian ... bench:     430,478 ns/iter (+/- 1,344)
test uint128_11::write_big_endian    ... bench:     430,517 ns/iter (+/- 570)
test uint128_11::write_little_endian ... bench:     430,551 ns/iter (+/- 601)
test uint128_11::write_native_endian ... bench:     430,595 ns/iter (+/- 1,627)
test uint128_12::write_big_endian    ... bench:     430,564 ns/iter (+/- 388)
test uint128_12::write_little_endian ... bench:     430,537 ns/iter (+/- 1,407)
test uint128_12::write_native_endian ... bench:     430,382 ns/iter (+/- 1,661)
test uint128_13::write_big_endian    ... bench:     430,968 ns/iter (+/- 5,490)
test uint128_13::write_little_endian ... bench:     430,434 ns/iter (+/- 1,289)
test uint128_13::write_native_endian ... bench:     430,464 ns/iter (+/- 1,850)
test uint128_14::write_big_endian    ... bench:     430,412 ns/iter (+/- 465)
test uint128_14::write_little_endian ... bench:     430,474 ns/iter (+/- 1,471)
test uint128_14::write_native_endian ... bench:     430,452 ns/iter (+/- 304)
test uint128_15::write_big_endian    ... bench:     430,942 ns/iter (+/- 757)
test uint128_15::write_little_endian ... bench:     430,568 ns/iter (+/- 2,904)
test uint128_15::write_native_endian ... bench:     430,442 ns/iter (+/- 360)
test uint128_16::write_big_endian    ... bench:     473,708 ns/iter (+/- 2,612)
test uint128_16::write_little_endian ... bench:     475,082 ns/iter (+/- 3,644)
test uint128_16::write_native_endian ... bench:     473,935 ns/iter (+/- 3,283)
test uint128_1::write_big_endian     ... bench:     107,602 ns/iter (+/- 204)
test uint128_1::write_little_endian  ... bench:     107,602 ns/iter (+/- 75)
test uint128_1::write_native_endian  ... bench:     107,614 ns/iter (+/- 1,337)
test uint128_2::write_big_endian     ... bench:     258,466 ns/iter (+/- 369)
test uint128_2::write_little_endian  ... bench:     279,828 ns/iter (+/- 1,399)
test uint128_2::write_native_endian  ... bench:     279,815 ns/iter (+/- 1,117)
test uint128_3::write_big_endian     ... bench:     258,530 ns/iter (+/- 21,861)
test uint128_3::write_little_endian  ... bench:     280,171 ns/iter (+/- 1,016)
test uint128_3::write_native_endian  ... bench:     280,253 ns/iter (+/- 1,783)
test uint128_4::write_big_endian     ... bench:     258,387 ns/iter (+/- 1,624)
test uint128_4::write_little_endian  ... bench:     258,699 ns/iter (+/- 1,570)
test uint128_4::write_native_endian  ... bench:     258,512 ns/iter (+/- 1,134)
test uint128_5::write_big_endian     ... bench:     258,658 ns/iter (+/- 1,059)
test uint128_5::write_little_endian  ... bench:     258,456 ns/iter (+/- 987)
test uint128_5::write_native_endian  ... bench:     258,645 ns/iter (+/- 1,481)
test uint128_6::write_big_endian     ... bench:     279,821 ns/iter (+/- 1,552)
test uint128_6::write_little_endian  ... bench:     258,402 ns/iter (+/- 19,638)
test uint128_6::write_native_endian  ... bench:     238,185 ns/iter (+/- 23,495)
test uint128_7::write_big_endian     ... bench:     259,410 ns/iter (+/- 22,949)
test uint128_7::write_little_endian  ... bench:     257,303 ns/iter (+/- 22,307)
test uint128_7::write_native_endian  ... bench:     258,294 ns/iter (+/- 1,672)
test uint128_8::write_big_endian     ... bench:     236,797 ns/iter (+/- 2,352)
test uint128_8::write_little_endian  ... bench:     236,786 ns/iter (+/- 1,905)
test uint128_8::write_native_endian  ... bench:     236,738 ns/iter (+/- 1,616)
test uint128_9::write_big_endian     ... bench:     430,568 ns/iter (+/- 1,620)
test uint128_9::write_little_endian  ... bench:     430,567 ns/iter (+/- 3,753)
test uint128_9::write_native_endian  ... bench:     430,459 ns/iter (+/- 257)

@fintelia
Copy link
Copy Markdown
Contributor Author

fintelia commented Apr 3, 2024 •
edited
Loading

And if the byte count is not black_box'd and gets inlined...

On master:

test uint_1::write_big_endian        ... bench:      21,528 ns/iter (+/- 120)
test uint_1::write_little_endian     ... bench:      21,529 ns/iter (+/- 109)
test uint_1::write_native_endian     ... bench:      21,532 ns/iter (+/- 162)
test uint_2::write_big_endian        ... bench:      21,518 ns/iter (+/- 14)
test uint_2::write_little_endian     ... bench:      21,518 ns/iter (+/- 18)
test uint_2::write_native_endian     ... bench:      21,518 ns/iter (+/- 12)
test uint_3::write_big_endian        ... bench:      21,518 ns/iter (+/- 35)
test uint_3::write_little_endian     ... bench:      21,518 ns/iter (+/- 16)
test uint_3::write_native_endian     ... bench:      21,518 ns/iter (+/- 107)
test uint_4::write_big_endian        ... bench:      21,518 ns/iter (+/- 32)
test uint_4::write_little_endian     ... bench:      21,523 ns/iter (+/- 161)
test uint_4::write_native_endian     ... bench:      21,555 ns/iter (+/- 179)
test uint_5::write_big_endian        ... bench:      21,549 ns/iter (+/- 154)
test uint_5::write_little_endian     ... bench:      21,602 ns/iter (+/- 235)
test uint_5::write_native_endian     ... bench:      21,555 ns/iter (+/- 166)
test uint_6::write_big_endian        ... bench:      21,518 ns/iter (+/- 20)
test uint_6::write_little_endian     ... bench:      21,518 ns/iter (+/- 61)
test uint_6::write_native_endian     ... bench:      21,521 ns/iter (+/- 203)
test uint_7::write_big_endian        ... bench:      21,518 ns/iter (+/- 13)
test uint_7::write_little_endian     ... bench:      21,518 ns/iter (+/- 41)
test uint_7::write_native_endian     ... bench:      21,518 ns/iter (+/- 22)
test uint_8::write_big_endian        ... bench:      21,518 ns/iter (+/- 9)
test uint_8::write_little_endian     ... bench:      21,517 ns/iter (+/- 14)
test uint_8::write_native_endian     ... bench:      21,518 ns/iter (+/- 12)

test uint128_10::write_big_endian    ... bench:      21,522 ns/iter (+/- 48)
test uint128_10::write_little_endian ... bench:      21,518 ns/iter (+/- 29)
test uint128_10::write_native_endian ... bench:      21,519 ns/iter (+/- 1,763)
test uint128_11::write_big_endian    ... bench:      21,518 ns/iter (+/- 60)
test uint128_11::write_little_endian ... bench:      21,517 ns/iter (+/- 13)
test uint128_11::write_native_endian ... bench:      21,518 ns/iter (+/- 79)
test uint128_12::write_big_endian    ... bench:      21,517 ns/iter (+/- 8)
test uint128_12::write_little_endian ... bench:      21,517 ns/iter (+/- 11)
test uint128_12::write_native_endian ... bench:      21,517 ns/iter (+/- 20)
test uint128_13::write_big_endian    ... bench:      21,517 ns/iter (+/- 29)
test uint128_13::write_little_endian ... bench:      21,517 ns/iter (+/- 12)
test uint128_13::write_native_endian ... bench:      21,517 ns/iter (+/- 12)
test uint128_14::write_big_endian    ... bench:      21,517 ns/iter (+/- 21)
test uint128_14::write_little_endian ... bench:      21,517 ns/iter (+/- 9)
test uint128_14::write_native_endian ... bench:      21,517 ns/iter (+/- 18)
test uint128_15::write_big_endian    ... bench:      21,517 ns/iter (+/- 20)
test uint128_15::write_little_endian ... bench:      21,517 ns/iter (+/- 11)
test uint128_15::write_native_endian ... bench:      21,517 ns/iter (+/- 11)
test uint128_16::write_big_endian    ... bench:      21,519 ns/iter (+/- 66)
test uint128_16::write_little_endian ... bench:      21,518 ns/iter (+/- 31)
test uint128_16::write_native_endian ... bench:      21,517 ns/iter (+/- 34)
test uint128_1::write_big_endian     ... bench:      21,518 ns/iter (+/- 12)
test uint128_1::write_little_endian  ... bench:      21,517 ns/iter (+/- 15)
test uint128_1::write_native_endian  ... bench:      21,518 ns/iter (+/- 45)
test uint128_2::write_big_endian     ... bench:      21,518 ns/iter (+/- 22)
test uint128_2::write_little_endian  ... bench:      21,517 ns/iter (+/- 12)
test uint128_2::write_native_endian  ... bench:      21,517 ns/iter (+/- 24)
test uint128_3::write_big_endian     ... bench:      21,522 ns/iter (+/- 37)
test uint128_3::write_little_endian  ... bench:      21,518 ns/iter (+/- 9)
test uint128_3::write_native_endian  ... bench:      21,517 ns/iter (+/- 10)
test uint128_4::write_big_endian     ... bench:      21,526 ns/iter (+/- 728)
test uint128_4::write_little_endian  ... bench:      21,526 ns/iter (+/- 29)
test uint128_4::write_native_endian  ... bench:      21,540 ns/iter (+/- 281)
test uint128_5::write_big_endian     ... bench:      21,524 ns/iter (+/- 199)
test uint128_5::write_little_endian  ... bench:      21,816 ns/iter (+/- 551)
test uint128_5::write_native_endian  ... bench:      21,571 ns/iter (+/- 932)
test uint128_6::write_big_endian     ... bench:      21,591 ns/iter (+/- 8,116)
test uint128_6::write_little_endian  ... bench:      21,527 ns/iter (+/- 48)
test uint128_6::write_native_endian  ... bench:      21,519 ns/iter (+/- 85)
test uint128_7::write_big_endian     ... bench:      21,550 ns/iter (+/- 177)
test uint128_7::write_little_endian  ... bench:      21,551 ns/iter (+/- 105)
test uint128_7::write_native_endian  ... bench:      21,519 ns/iter (+/- 97)
test uint128_8::write_big_endian     ... bench:      21,594 ns/iter (+/- 740)
test uint128_8::write_little_endian  ... bench:      21,519 ns/iter (+/- 208)
test uint128_8::write_native_endian  ... bench:      21,525 ns/iter (+/- 427)
test uint128_9::write_big_endian     ... bench:      21,523 ns/iter (+/- 216)
test uint128_9::write_little_endian  ... bench:      21,517 ns/iter (+/- 132)
test uint128_9::write_native_endian  ... bench:      21,517 ns/iter (+/- 98)

With this PR:

test uint_1::write_big_endian        ... bench:      21,538 ns/iter (+/- 38)
test uint_1::write_little_endian     ... bench:      21,540 ns/iter (+/- 80)
test uint_1::write_native_endian     ... bench:      21,528 ns/iter (+/- 34)
test uint_2::write_big_endian        ... bench:      21,540 ns/iter (+/- 63)
test uint_2::write_little_endian     ... bench:      21,531 ns/iter (+/- 34)
test uint_2::write_native_endian     ... bench:      21,543 ns/iter (+/- 66)
test uint_3::write_big_endian        ... bench:      21,535 ns/iter (+/- 44)
test uint_3::write_little_endian     ... bench:      21,540 ns/iter (+/- 39)
test uint_3::write_native_endian     ... bench:      21,534 ns/iter (+/- 58)
test uint_4::write_big_endian        ... bench:      21,540 ns/iter (+/- 51)
test uint_4::write_little_endian     ... bench:      21,526 ns/iter (+/- 48)
test uint_4::write_native_endian     ... bench:      21,533 ns/iter (+/- 41)
test uint_5::write_big_endian        ... bench:      21,537 ns/iter (+/- 37)
test uint_5::write_little_endian     ... bench:      21,526 ns/iter (+/- 35)
test uint_5::write_native_endian     ... bench:      21,528 ns/iter (+/- 32)
test uint_6::write_big_endian        ... bench:      21,528 ns/iter (+/- 33)
test uint_6::write_little_endian     ... bench:      21,540 ns/iter (+/- 75)
test uint_6::write_native_endian     ... bench:      21,535 ns/iter (+/- 32)
test uint_7::write_big_endian        ... bench:      21,542 ns/iter (+/- 447)
test uint_7::write_little_endian     ... bench:      21,531 ns/iter (+/- 39)
test uint_7::write_native_endian     ... bench:      21,532 ns/iter (+/- 35)
test uint_8::write_big_endian        ... bench:      21,550 ns/iter (+/- 374)
test uint_8::write_little_endian     ... bench:      21,547 ns/iter (+/- 64)
test uint_8::write_native_endian     ... bench:      21,548 ns/iter (+/- 74)

test uint128_10::write_big_endian    ... bench:      21,534 ns/iter (+/- 71)
test uint128_10::write_little_endian ... bench:      21,541 ns/iter (+/- 38)
test uint128_10::write_native_endian ... bench:      21,533 ns/iter (+/- 37)
test uint128_11::write_big_endian    ... bench:      21,545 ns/iter (+/- 76)
test uint128_11::write_little_endian ... bench:      21,546 ns/iter (+/- 111)
test uint128_11::write_native_endian ... bench:      21,527 ns/iter (+/- 51)
test uint128_12::write_big_endian    ... bench:      21,529 ns/iter (+/- 39)
test uint128_12::write_little_endian ... bench:      21,528 ns/iter (+/- 38)
test uint128_12::write_native_endian ... bench:      21,546 ns/iter (+/- 344)
test uint128_13::write_big_endian    ... bench:      21,542 ns/iter (+/- 120)
test uint128_13::write_little_endian ... bench:      21,537 ns/iter (+/- 35)
test uint128_13::write_native_endian ... bench:      21,535 ns/iter (+/- 37)
test uint128_14::write_big_endian    ... bench:      21,525 ns/iter (+/- 32)
test uint128_14::write_little_endian ... bench:      21,530 ns/iter (+/- 33)
test uint128_14::write_native_endian ... bench:      21,542 ns/iter (+/- 52)
test uint128_15::write_big_endian    ... bench:      21,537 ns/iter (+/- 40)
test uint128_15::write_little_endian ... bench:      21,527 ns/iter (+/- 36)
test uint128_15::write_native_endian ... bench:      21,527 ns/iter (+/- 50)
test uint128_16::write_big_endian    ... bench:      21,526 ns/iter (+/- 124)
test uint128_16::write_little_endian ... bench:      21,526 ns/iter (+/- 126)
test uint128_16::write_native_endian ... bench:      21,527 ns/iter (+/- 136)
test uint128_1::write_big_endian     ... bench:      21,525 ns/iter (+/- 120)
test uint128_1::write_little_endian  ... bench:      21,526 ns/iter (+/- 132)
test uint128_1::write_native_endian  ... bench:      21,526 ns/iter (+/- 163)
test uint128_2::write_big_endian     ... bench:      21,525 ns/iter (+/- 124)
test uint128_2::write_little_endian  ... bench:      21,526 ns/iter (+/- 163)
test uint128_2::write_native_endian  ... bench:      21,530 ns/iter (+/- 142)
test uint128_3::write_big_endian     ... bench:      21,526 ns/iter (+/- 157)
test uint128_3::write_little_endian  ... bench:      21,526 ns/iter (+/- 200)
test uint128_3::write_native_endian  ... bench:      21,524 ns/iter (+/- 142)
test uint128_4::write_big_endian     ... bench:      21,529 ns/iter (+/- 146)
test uint128_4::write_little_endian  ... bench:      21,523 ns/iter (+/- 116)
test uint128_4::write_native_endian  ... bench:      21,526 ns/iter (+/- 124)
test uint128_5::write_big_endian     ... bench:      21,528 ns/iter (+/- 154)
test uint128_5::write_little_endian  ... bench:      21,526 ns/iter (+/- 121)
test uint128_5::write_native_endian  ... bench:      21,526 ns/iter (+/- 144)
test uint128_6::write_big_endian     ... bench:      21,555 ns/iter (+/- 118)
test uint128_6::write_little_endian  ... bench:      21,528 ns/iter (+/- 77)
test uint128_6::write_native_endian  ... bench:      21,572 ns/iter (+/- 2,543)
test uint128_7::write_big_endian     ... bench:      21,526 ns/iter (+/- 65)
test uint128_7::write_little_endian  ... bench:      21,536 ns/iter (+/- 59)
test uint128_7::write_native_endian  ... bench:      21,526 ns/iter (+/- 59)
test uint128_8::write_big_endian     ... bench:      21,559 ns/iter (+/- 67)
test uint128_8::write_little_endian  ... bench:      21,540 ns/iter (+/- 61)
test uint128_8::write_native_endian  ... bench:      21,527 ns/iter (+/- 54)
test uint128_9::write_big_endian     ... bench:      21,537 ns/iter (+/- 129)
test uint128_9::write_little_endian  ... bench:      21,533 ns/iter (+/- 126)
test uint128_9::write_native_endian  ... bench:      21,552 ns/iter (+/- 131)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fintelia @BurntSushi