Skip to content

fix(release): switch to workflow_run trigger, disable PyPI publishing#58

Merged
williaby merged 1 commit into
mainfrom
fix/psr-release-workflow-bugs
May 28, 2026
Merged

fix(release): switch to workflow_run trigger, disable PyPI publishing#58
williaby merged 1 commit into
mainfrom
fix/psr-release-workflow-bugs

Conversation

@williaby
Copy link
Copy Markdown
Contributor

Summary

  • Change release trigger from push: branches to workflow_run: ["CI"] so releases are gated behind CI success
  • Update concurrency group key to head_branch for workflow_run events
  • Move permissions to job level; workflow-level drops to contents: read
  • Set publish-to-pypi: false (private repo — no PyPI publishing)
  • Set run-tests: false + skip-tests-reason (CI already validated tests upstream)
  • Add secrets: inherit for reusable workflow token passthrough

Context

Part of fleet-wide replication of PSR v10.5.3 bug mitigations. The core fixes (vcs_release, commit:false, HEAD attachment) live in the org-level reusable workflow (ByronWilliamsCPA/.github PR #184). This PR updates the caller to use the CI-gated trigger pattern.

Test plan

  • Confirm CI workflow passes on this PR
  • After merging ByronWilliamsCPA/.github PR #184, verify a merge to main triggers the release workflow via workflow_run

Generated with Claude Code

- Trigger changed from push:branches to workflow_run:workflows:["CI"]
  so releases only fire after CI passes (not on every push to main)
- Added job-level if guard for workflow_run conclusion == success
- publish-to-pypi set to false (no repos currently publish to PyPI)
- run-tests set to false with skip-tests-reason (CI already ran them)
- Concurrency group updated to use workflow_run.head_branch

Applies PSR v10.5.3 mitigations from ByronWilliamsCPA/.claude reference
implementation (validated end-to-end on 2026-05-28 with v0.14.0 release).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 28, 2026 13:17
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Warning

Review limit reached

@williaby, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 54 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ebf29169-eb3f-4196-b33f-dada64c5ddf3

📥 Commits

Reviewing files that changed from the base of the PR and between bf74a00 and 6cc3b6f.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/psr-release-workflow-bugs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@mergify
Copy link
Copy Markdown

mergify Bot commented May 28, 2026

❌ This pull request cannot be evaluated by Mergify

Details

files are inaccessible

@sonarqubecloud
Copy link
Copy Markdown

@mergify
Copy link
Copy Markdown

mergify Bot commented May 28, 2026

❌ This pull request cannot be evaluated by Mergify

Details

files are inaccessible

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s release workflow to only run after the CI workflow completes successfully (via workflow_run), and adjusts release inputs to reflect that CI already validated tests and that PyPI publishing is disabled for this repo.

Changes:

  • Switch release trigger from push to workflow_run on the CI workflow, and gate the job on upstream success.
  • Update the release concurrency group to use the upstream run’s head_branch (with fallback).
  • Disable running tests inside the release reusable workflow and provide a skip reason; keep PyPI publishing disabled.

# Prevent concurrent releases
concurrency:
group: "release-${{ github.ref }}"
group: "release-${{ github.event.workflow_run.head_branch || github.ref_name }}"
Comment on lines +49 to 52
if: >-
github.event_name == 'workflow_dispatch' ||
github.event.workflow_run.conclusion == 'success'
uses: ByronWilliamsCPA/.github/.github/workflows/python-release.yml@961eb17d8e9b7fe0d8bfc5dbe9d23c824484fb11 # main
Comment on lines 59 to 63
publish-to-pypi: false # re-enable when PyPI project is registered
pypi-package-name: 'rag-processor'
run-tests: true
run-tests: false
skip-tests-reason: 'Tests run in upstream CI pipeline before this workflow fires'
no-build: false
@williaby williaby merged commit 31f4d5b into main May 28, 2026
36 checks passed
@williaby williaby deleted the fix/psr-release-workflow-bugs branch May 28, 2026 16:30
Copilot AI mentioned this pull request May 28, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants