Option to specify context when creating file and location objects#282
Open
NathanBaulch wants to merge 2 commits intoC2FO:mainfrom
Open
Option to specify context when creating file and location objects#282NathanBaulch wants to merge 2 commits intoC2FO:mainfrom
NathanBaulch wants to merge 2 commits intoC2FO:mainfrom
Conversation
funkyshu
requested changes
Sep 16, 2025
Member
funkyshu
left a comment
There was a problem hiding this comment.
I'm still thinking this through but I think the s3 example suggestions make sense.
eca9a4b to
3385e43
Compare
3385e43 to
c1a5761
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something I find lacking in this library is the ability to trace outbound requests. It's possible to configure instrumented clients for most backends but common tracing tools like OpenTelemetry use context to pass state around.
Rather than breaking every API by adding
context.Contextarguments (as previously discussed), I propose thegs.WithContextpattern be applied more widely toNewLocationandNewFile. This would allow a web application to have a single sharedFileSystem(orLocation) and inject the current request context when working with specific files.Here's a minimal example:
The other nice thing about this approach is it doesn't pollute the API for backends that don't support context, like
mem,osandsftp.This is a non-breaking additive change so in theory it could be included in
v7, but I understand if it needs to wait forv8.