CTDC-1719: add ancestor node traceback feature by nathanhuangnih · Pull Request #166 · CBIIT/Data-Model-Navigator

nathanhuangnih · 2025-12-03T21:43:47Z

Clicking a node filters the graph to show only that node and its parent path to root
Filter clears when closing node or clicking canvas
Uses Redux state and BFS traversal to find ancestors

Copilot

Pull request overview

This PR adds an ancestor node traceback feature that allows users to filter the graph visualization to show only a selected node and its parent path to the root. The feature integrates with the existing Redux state management and uses BFS (Breadth-First Search) traversal to identify ancestor relationships.

Key Changes:

Implements ancestor node filtering functionality using BFS traversal
Adds Redux actions and state management for the ancestor filter
Integrates filter clearing with existing UI interactions (node collapse, canvas click)

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`src/components/ModelNavigator/DataDictionary/Store/reducers/graph.js`	Adds `ancestorFilterNodeIds` state and reducer cases for ancestor filtering; computes ancestor nodes when a node is focused
`src/components/ModelNavigator/DataDictionary/Store/actions/graph.js`	Defines `setAncestorFilter` and `clearAncestorFilter` action creators
`src/components/ModelNavigator/DataDictionary/ReactFlowGraph/Node/ReduxNodeView.jsx`	Connects `onClearAncestorFilter` action to Redux dispatcher
`src/components/ModelNavigator/DataDictionary/ReactFlowGraph/Node/NodeView.jsx`	Calls `onClearAncestorFilter` when the node view is collapsed
`src/components/ModelNavigator/DataDictionary/ReactFlowGraph/Canvas/CanvasHelper.jsx`	Implements `buildParentMap` and `getAncestorNodes` helper functions for BFS traversal
`src/components/ModelNavigator/DataDictionary/ReactFlowGraph/Canvas/CanvasController.jsx`	Filters nodes and edges based on `ancestorFilterNodeIds`; clears filter on canvas click

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-03T21:55:32Z

src/components/ModelNavigator/DataDictionary/Store/reducers/graph.js

@@ -7,6 +7,7 @@ import {
  onCnavasWidthChange,


Corrected spelling of 'Cnavas' to 'Canvas'.

Suggested change

onCnavasWidthChange,

onCanvasWidthChange,

Copilot · 2025-12-03T21:55:32Z

src/components/ModelNavigator/DataDictionary/Store/reducers/graph.js

+      const parentMap = buildParentMap(state.dictionary);
+      const ancestorNodeIds = getAncestorNodes(action.nodeID, parentMap);


Building the parent map on every node focus is inefficient. Consider memoizing the parent map or computing it once when the dictionary changes, then storing it in Redux state to avoid recalculating on each node interaction.

Copilot · 2025-12-03T21:55:33Z

src/components/ModelNavigator/DataDictionary/Store/actions/graph.js

 });

+export const setAncestorFilter = (ancestorNodeIds) => ({
+  type: 'SET_ANCESTOR_FILTER',


Action type 'SET_ANCESTOR_FILTER' should be defined as a constant in actionTypes file to maintain consistency with other actions like 'ON_REACT_FLOW_NODE_FOCUS'. This prevents typos and makes refactoring easier.

Suggested change

type: 'SET_ANCESTOR_FILTER',

type: actionTypes.SET_ANCESTOR_FILTER,

Copilot · 2025-12-03T21:55:33Z

src/components/ModelNavigator/DataDictionary/Store/actions/graph.js

+});
+
+export const clearAncestorFilter = () => ({
+  type: 'CLEAR_ANCESTOR_FILTER',


Action type 'CLEAR_ANCESTOR_FILTER' should be defined as a constant in actionTypes file to maintain consistency with other actions like 'ON_REACT_FLOW_NODE_FOCUS'. This prevents typos and makes refactoring easier.

Suggested change

type: 'CLEAR_ANCESTOR_FILTER',

type: actionTypes.CLEAR_ANCESTOR_FILTER,

Copilot · 2025-12-03T21:55:33Z

src/components/ModelNavigator/DataDictionary/ReactFlowGraph/Node/ReduxNodeView.jsx

  onViewTable: (hide) => dispatch(setOverlayPropertyTableHidden(hide)),
-  onCollapseNodeView: () => {dispatch(onPanelViewClick())}
+  onCollapseNodeView: () => {dispatch(onPanelViewClick())},
+  onClearAncestorFilter: () => dispatch({ type: 'CLEAR_ANCESTOR_FILTER' }),


Dispatching action with inline type string bypasses the imported action creator. Use dispatch(clearAncestorFilter()) from the actions/graph.js file to maintain consistency and type safety.

Copilot · 2025-12-03T21:55:34Z

src/components/ModelNavigator/DataDictionary/ReactFlowGraph/Canvas/CanvasController.jsx

-  onGraphPanelClick: () => {dispatch(onPanelViewClick())},
+  onGraphPanelClick: () => {
+    dispatch(onPanelViewClick());
+    dispatch({ type: 'CLEAR_ANCESTOR_FILTER' });


Dispatching action with inline type string bypasses the imported action creator. Use dispatch(clearAncestorFilter()) from the actions/graph.js file to maintain consistency and type safety.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-27T21:25:36Z

src/components/ModelNavigator/DataDictionary/Store/actions/graph.js

+  type: 'SET_ANCESTOR_FILTER',
+  ancestorNodeIds,
+});
+
+export const clearAncestorFilter = () => ({
+  type: 'CLEAR_ANCESTOR_FILTER',


The action types 'SET_ANCESTOR_FILTER' and 'CLEAR_ANCESTOR_FILTER' are hardcoded string literals. These should be defined as constants in the actionTypes file to maintain consistency with the existing pattern in the codebase and prevent typos.

Suggested change

type: 'SET_ANCESTOR_FILTER',

ancestorNodeIds,

});

export const clearAncestorFilter = () => ({

type: 'CLEAR_ANCESTOR_FILTER',

type: actionTypes.SET_ANCESTOR_FILTER,

ancestorNodeIds,

});

export const clearAncestorFilter = () => ({

type: actionTypes.CLEAR_ANCESTOR_FILTER,

amattu2

I'm doing some initial testing, and noticing an odd behavior with some nodes not showing the initial Node View popup. Maybe this is pre-existing behavior? It's probably worth fixing as apart of these changes if it's not a huge scope creep. LMK

Screen.Recording.2026-02-09.at.10.05.58.AM.mov

amattu2 · 2026-03-06T21:07:03Z

Discussed in a call an issue (??) where the graph resets the placement of nodes after dismissing the contextual popup that appears when clicking a node. Pending confirmation from CTDC if this needs to be fixed, or if it's expected behavior. If no changes are made, we can merge this in.

add ancestor node traceback feature

51b5953

nathanhuangnih requested review from Nahomtes, amattu2, Copilot and jonkiky December 3, 2025 21:43

Copilot AI reviewed Dec 3, 2025

View reviewed changes

amattu2 requested a review from Alejandro-Vega December 3, 2025 23:17

Nahomtes and others added 3 commits December 5, 2025 15:41

fix: Typo in onCanvasWidthChange function name

edcecb7

Merge branch 'CRDC-DH' into CTDC-1719-ancestor-traceback-feature

9ca85cf

Merge branch 'CRDC-DH' into CTDC-1719-ancestor-traceback-feature

fe7fb00

amattu2 requested a review from a team January 27, 2026 18:57

nathanhuangnih requested a review from Copilot January 27, 2026 21:24

Copilot AI reviewed Jan 27, 2026

View reviewed changes

amattu2 requested changes Feb 9, 2026

View reviewed changes

amattu2 added the 📝 Change Requested label Feb 9, 2026

amattu2 mentioned this pull request Feb 9, 2026

CTDC-1719: ancestor node traceback feature #165

Closed

amattu2 added DO-NOT-MERGE and removed 📝 Change Requested labels Mar 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CTDC-1719: add ancestor node traceback feature#166

CTDC-1719: add ancestor node traceback feature#166
nathanhuangnih wants to merge 4 commits intoCRDC-DHfrom
CTDC-1719-ancestor-traceback-feature

nathanhuangnih commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 3, 2025

Uh oh!

Copilot AI Dec 3, 2025

Uh oh!

Copilot AI Dec 3, 2025

Uh oh!

Copilot AI Dec 3, 2025

Uh oh!

Copilot AI Dec 3, 2025

Uh oh!

Copilot AI Dec 3, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

amattu2 left a comment

Uh oh!

amattu2 commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		const parentMap = buildParentMap(state.dictionary);
		const ancestorNodeIds = getAncestorNodes(action.nodeID, parentMap);

	type: 'SET_ANCESTOR_FILTER',
	type: actionTypes.SET_ANCESTOR_FILTER,

	type: 'CLEAR_ANCESTOR_FILTER',
	type: actionTypes.CLEAR_ANCESTOR_FILTER,

Conversation

nathanhuangnih commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

amattu2 left a comment

Choose a reason for hiding this comment

Uh oh!

amattu2 commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants