fix: deletion UI consistency fixed#872
Open
devxdebanjan wants to merge 2 commits intoCCExtractor:mainfrom
Open
fix: deletion UI consistency fixed#872devxdebanjan wants to merge 2 commits intoCCExtractor:mainfrom
devxdebanjan wants to merge 2 commits intoCCExtractor:mainfrom
Conversation
Member
|
ideally, we'd like a smooth experience so some animation makes more sense than a sudden change. |
Contributor
Author
|
The animation that was currently in use was not consistent as the alarm tabs would move down once it entered the deletion mode. This would affect much more as the number of alarms, in the list above the alarm being selected, increases. So if an animation has to be in place, instead of shifting tabs vertically we have to either shrink or make a bounce effect horizontally or add component animation into the tab (like the alarm toggle button turns into a radio button) so that the tab places are fixed. What do you prefer between these? Or is there any other animation better suited? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Whenever an alarm is longpressed, the app goes into deletion mode. This deletion mode however shows the alarm separation getting wider with significant frame drops at times making it laggy and inconsistent. This PR fixes that.
Proposed Changes
Fixes #871
This issue is fixed and addressed by this PR. However, please let me know if you want some animation inside the alarm card itself, which will make it both consistent and less sudden for going into Deletion mode from Normal mode.
Screenshots
A Screen Recording for after the fix:
fix.mp4
Checklist