fix(isar): prevent bounds crash in doesAlarmExist (#878)#879
Open
dorodb-web22 wants to merge 1 commit intoCCExtractor:mainfrom
Open
fix(isar): prevent bounds crash in doesAlarmExist (#878)#879dorodb-web22 wants to merge 1 commit intoCCExtractor:mainfrom
dorodb-web22 wants to merge 1 commit intoCCExtractor:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #878
When i was reading through the DB providers and i noticed that doesAlarmExist in the Isar provider tries to grab
alarms[0].alarmIDto pass to a debug print before it ever checks if the list actually has anything in it.means an existence check on an alarm ID that isn't saved in the DB yet, Isar returns an empty list, and the
printline immediately crashes the app with aRangeError.Proposed Changes
I have
printblock inside anif (alarms.isNotEmpty)guard now .. so it's ok to call the method on fresh/unsaved alarm IDs.Screenshots
N/A — data layer fix.
Checklist