test(model): add unit tests for AlarmModel (#882)#883
Open
dorodb-web22 wants to merge 1 commit intoCCExtractor:mainfrom
Open
test(model): add unit tests for AlarmModel (#882)#883dorodb-web22 wants to merge 1 commit intoCCExtractor:mainfrom
dorodb-web22 wants to merge 1 commit intoCCExtractor:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #882
Description
Added a proper unit test file for AlarmModel. noticed while working on some other bugs that the data models don't have any test coverage right now, so i wrote these to lock down the expected behavior.
Proposed Changes
maxSnoozeCountdefaulting to 3)mainAlarmTimeconditional logic for shared alarms)Besides, i left out tests for the
fromJsonconstructor intentionally because it's currently broken on main ... there's an open PR #868 to fix that separately).*Screenshots
n/a (unit tests only)
Checklist