Conversation
- addition of the `force_partitioning` parameter to the test suite
harryswift01
approved these changes
Nov 18, 2025
Member
There was a problem hiding this comment.
Thank you very much for adding these changes @ioanaapapa, it is greatly appreciated! Initially we wanted to wait for a stable release of CodeEntropy before we would allow users to change certain parameters like the force_partitioning but I think we are now at that stage where we're happy for users to tweak these parameters. I'm very happy to approve and merge this in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #192, allowing the force_partitioning argument to be changed.
Changes
Force_partitioning argument changes value used in calculation:
Impact
Force_partitioning parameter can now be changed as shown below for two examples with force_partitioning = 0.5 and force_partitioning = 1.
While we haven't yet identified any cases for which a value different to 0.5 is necessary, changing this might be useful in the future and is useful for investigating vibrational entropy terms, especially the rovibrational one.
Warning about using a different value to 0.5 remains and displays the default value, as shown below (example above was computed before this change. Example below was computed for a small number of frames just to illustrate this change) :
Closes: Force partitioning remains 0.5 even if changing the parameter #192