Open
Conversation
seongmin221
reviewed
Jun 4, 2023
Instagram-iOS/Instagram-iOS/Screens/DMList/Cell/DMCollectionViewCell.swift
Outdated
Show resolved
Hide resolved
seongmin221
reviewed
Jun 4, 2023
Instagram-iOS/Instagram-iOS/Screens/DMList/Cell/DMCollectionViewCell.swift
Outdated
Show resolved
Hide resolved
seongmin221
reviewed
Jun 4, 2023
Comment on lines
+64
to
+66
| private func register() { | ||
| storyCollectionView.register(DMCollectionViewCell.self, forCellWithReuseIdentifier: DMCollectionViewCell.identifier) | ||
| } |
Contributor
There was a problem hiding this comment.
p3;
요건 굳이 함수로 안빼도 되고 DMCollectionView 선언한 곳에 넣어도 될 듯 하네요 !!
seongmin221
reviewed
Jun 4, 2023
|
|
||
| private func setLayout() { | ||
|
|
||
| backgroundColor = .white1 |
Contributor
There was a problem hiding this comment.
p1;
요건 setLayout 보다는 setStyle() 에 들어가는게 좋다고 봅니다 !
seongmin221
reviewed
Jun 4, 2023
Comment on lines
106
to
113
| private func setSearchTextFieldUI() { | ||
|
|
||
| searchTextField.layer.cornerRadius = 10 | ||
| searchTextField.backgroundColor = .gray5 | ||
| searchTextField.font = .body | ||
| // searchTextField.attributedPlaceholder = NSAttributedString(string: "검색", attributes: [NSAttributedString.Key.foregroundColor: UIColor.lightGray]) | ||
|
|
||
| } |
Contributor
There was a problem hiding this comment.
p2;
혹시 요것도 textField 선언부가 아니고 함수로 빼 둔 이유가 있을까요 ??
따로 이유가 없다면 선언부에 넣으셔도 좋을 것 같아요 !!
seongmin221
reviewed
Jun 4, 2023
Comment on lines
74
to
76
| override func setStyle() { | ||
|
|
||
| } |
Contributor
There was a problem hiding this comment.
p2;
사용하지 않는다면 지워주십쇼 !!
(hoxy baseView의 setStyle에 backgroundcolor 이런거 없앨라고 비운 채로 선언해두신...걸까요..?)
seongmin221
reviewed
Jun 4, 2023
Contributor
seongmin221
left a comment
seongmin221
left a comment
There was a problem hiding this comment.
고생하셨습니다 !!
몇 가지 수정사항 보여서 적어뒀어요 :)
이제 슬슬 api 도 연결 해보자구요 ~~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📱 Screenshot
👩💻 Contents
DMList의 뼈대 UI구현했습니다!
📣 Related Issue