Skip to content

session server BUGFIX allow binding on missing address #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeremie6wind wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

session server BUGFIX allow binding on missing address #606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/session_server.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ nc_sock_bind_inet(int sock, const char *address, uint16_t port, int is_ipv4)
struct sockaddr_storage saddr;
struct sockaddr_in *saddr4;
struct sockaddr_in6 *saddr6;
int opt = 1;

memset(&saddr, 0, sizeof(struct sockaddr_storage));

Expand All @@ -307,6 +308,11 @@ nc_sock_bind_inet(int sock, const char *address, uint16_t port, int is_ipv4)
return -1;
}

if (setsockopt(sock, IPPROTO_IP, IP_FREEBIND, &opt, sizeof(opt))) {
ERR(NULL, "Could not bind (%s).", strerror(errno));
return -1;
}

if (bind(sock, (struct sockaddr *)saddr4, sizeof(struct sockaddr_in)) == -1) {
ERR(NULL, "Could not bind %s:%" PRIu16 " (%s).", address, port, strerror(errno));
return -1;
Expand All @@ -328,6 +334,11 @@ nc_sock_bind_inet(int sock, const char *address, uint16_t port, int is_ipv4)
return -1;
}

if (setsockopt(sock, IPPROTO_IPV6, IPV6_FREEBIND, &opt, sizeof(opt))) {
ERR(NULL, "Could not bind (%s).", strerror(errno));
return -1;
}

if (bind(sock, (struct sockaddr *)saddr6, sizeof(struct sockaddr_in6)) == -1) {
ERR(NULL, "Could not bind [%s]:%" PRIu16 " (%s).", address, port, strerror(errno));
return -1;
Expand Down