Uses outer project's languages for tests#121
Merged
ryanmrichard merged 2 commits intomasterfrom Jun 23, 2025
Merged
Conversation
zachcran
previously approved these changes
Jun 17, 2025
Contributor
zachcran
left a comment
zachcran
left a comment
There was a problem hiding this comment.
LGTM. I left a suggestion for allowing the user to set a desired language list that may differ from the enabled languages, but it is not crucial for this PR so I'll leave it up to you to decide how to handle it (implement it, don't implement it, move it to an issue for the future, etc.).
Contributor
Author
|
@zachcran bumping the review request. |
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
Partially addresses #118.
Description
CMakeTest works by creating CMake projects for each test. Those projects need to invoke the
project()command. Previously, we had been hard-coding the language toC. This PR changes that so that we now use the languages the user is using.TODOs