Closed
Conversation
Contributor
Author
|
As was just pointed out to me in #122, using |
Contributor
|
@ryanmrichard I didn't realize that using the function names was deprecated. The inverse of this PR would be useful to warn about the deprecation. I don't know about the other repos, but CMaize will definitely need to be switched over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
Sort of related to #122, but does not fix it.
Description
To implicitly discourage people from using
CMAKETEST_TESTwhen a test should fail the example falls back to using the name of the function. I want to stop short of telling people not to use it in case we don't actually need to deprecate it.TODOs
R2g.