Conversation
Add additional "MSYS" checking for CMAKE_SYSTEM_NAME to support compilation under MSYS2.
|
Hi @pffang |
I usually need to build dlt console tools in MSYS2 and use them on Windows. And I also tried dlt-daemon and dlt-test-stress-client You can also check the change code. I didn't modify any logic, just fixed some compiling errors in MSYS2, and add a new GitHub action to check the building in MSYS2. Most compiling errors are char-subscripts and unused errors. The POSIX C functions isdigit/ispunct/isspace accept int input value not char, please check https://pubs.opengroup.org/onlinepubs/9699919799/functions/isdigit.html |
|
Look good to me, pls review @lti9hc |
| int ret; | ||
| int fd = -1; | ||
| int fifo_size; | ||
| DLT_UNUSED(fifo_size); |
There was a problem hiding this comment.
if it unused then we should remove
| else { | ||
| if(pattern.find("\"\"") != string::npos) { | ||
| json_sequence = json_sequence + strdup("null") + " "; | ||
| if(file.is_open()) { |
There was a problem hiding this comment.
"if" you try to put an if here, yes it makes sense and nice for secure code, but then in the else case, we need to log some fatal/error log I guess?
|
Please add warning in file cannot open case and rebase/fix conflict |
minminlittleshrimp
left a comment
There was a problem hiding this comment.
rework needed
|
Looks like the MSYS building issue was already fixed in recent changes. We can close this. |
Fix build issues in MSYS2, and add an MSYS2 action to check build issues.