Draft
Conversation
Collaborator
|
As briefly discussed offline: the core issue is here that NDVarArray is also an expression, right? But when do we actually allow for such nesting? I can't think of any case where arbitrary nesting in the constructor is allowed... So my preference would be to fix the type of NDVarArray such that I find the syntax of the overloads quite hard to parse, but maybe it's just a matter of getting used to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as follow-up to the discussion in #874
do we want this? its a lot of new syntax that was unnatural for me to read at first, but it shows that you can't nested lists
(there are 7-or-so other *args usages like this in globalconstraints)