Skip to content

Implement defer #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MattyTheHacker wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −5
Open

Implement defer #770

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3246164
Implement defer
MattyTheHacker May 15, 2026
da3924b
Make ephemeral
MattyTheHacker May 15, 2026
5afada8
Make defer call ephemeral in add_users command
MattyTheHacker May 15, 2026
33372e9
Merge main into fix-add-to-channel
automatic-pr-updater[bot] May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions cogs/add_users_to_threads_and_channels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,8 @@ async def add_user_to_channel(
)
return

await ctx.defer(ephemeral=True)

try:
user_to_add: discord.Member = await self.bot.get_member_from_str_id(user_id_str)
except ValueError:
Expand All @@ -229,7 +231,7 @@ async def add_user_to_channel(
else:
await self.add_users_or_roles_with_ping(user_to_add, ctx.channel)

await ctx.respond(
await ctx.followup.send(
content=(
f"Successfully added {user_to_add.mention} "
f"to the channel: {ctx.channel.mention}."
Expand Down Expand Up @@ -265,14 +267,14 @@ async def add_role_to_channel(
silent: bool, # noqa: FBT001
) -> None:
"""Command to add a role to a channel."""
if not isinstance(ctx.channel, discord.Thread) and not isinstance(
ctx.channel, discord.TextChannel
):
if not isinstance(ctx.channel, (discord.TextChannel, discord.Thread)):
await self.command_send_error(
ctx, message="This command can only be used in a text channel or thread."
)
return

await ctx.defer(ephemeral=True)

main_guild: discord.Guild = ctx.bot.main_guild

try:
Expand All @@ -295,7 +297,7 @@ async def add_role_to_channel(
else:
await self.add_users_or_roles_with_ping(role_to_add, ctx.channel)

await ctx.respond(
await ctx.followup.send(
content=f"Role {role_to_add.mention} has been added to the channel.",
ephemeral=True,
)
Loading