Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds two new exported functions to the challenge pages API: getSolution and checkSolution. These functions enable fetching challenge solutions via API and determining whether the UI should check for a solution based on solution state and submission status.
Key Changes:
- Added
getSolutionfunction to fetch challenge solutions from the API - Added
checkSolutionfunction to determine if the UI should retrieve a solution based on state - Exposed both functions through the main API surface in
main.js
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pages/challenge.js | Implements getSolution and checkSolution functions with API fetching and conditional logic |
| main.js | Exports new functions and adds checkSolution hook to _functions.challenge |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+154
to
+156
| if (solutionState == "hidden" || solutionState == "visible") { | ||
| return false; | ||
| } else if (solutionState == "solved" && submissionStatus === "correct") { |
There was a problem hiding this comment.
Inconsistent equality operators: use strict equality (===) for solutionState comparisons on line 154, matching the strict equality used for submissionStatus on line 156.
Suggested change
| if (solutionState == "hidden" || solutionState == "visible") { | |
| return false; | |
| } else if (solutionState == "solved" && submissionStatus === "correct") { | |
| if (solutionState === "hidden" || solutionState === "visible") { | |
| return false; | |
| } else if (solutionState === "solved" && submissionStatus === "correct") { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CTFd.pages.challenge.getSolutionCTFd.pages.challenge.checkSolution