fix: Single instance - present existing window on reactivation#213
Open
ptcodes wants to merge 1 commit intoCachyOS:developfrom
Open
fix: Single instance - present existing window on reactivation#213ptcodes wants to merge 1 commit intoCachyOS:developfrom
ptcodes wants to merge 1 commit intoCachyOS:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a second instance of the application was launched, GTK correctly routed the activate signal to the already-running instance, but connect_activate unconditionally called build_ui, creating a second window. Additionally, build_ui calls systemd_units::refresh_cache() which blocks the GTK main thread on D-Bus I/O, causing the first instance to hang.
Check if G_HELLO_WINDOW is already set in connect_activate and call window.present() to raise the existing window instead of rebuilding the UI.
Fixes #211