Closed
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Merge ci fixes
There was a problem hiding this comment.
Pull request overview
This PR applies PHP-CS-Fixer code style improvements to standardize code formatting across the repository. The changes focus on modernizing comment styles, array syntax, and string concatenation patterns while maintaining PHP 8.1+ compatibility.
Changes:
- Converted C-style block comments to single-line comments
- Modernized array syntax from
array()to[] - Standardized string concatenation spacing
- Updated PHPDoc formatting and improved documentation style
Reviewed changes
Copilot reviewed 104 out of 148 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.php-cs-fixer.dist.php |
Added PHP-CS-Fixer configuration file with PSR and PhpCsFixer rulesets |
composer.json |
Added composer file with php-cs-fixer as dev dependency |
.github/copilot-instructions.md |
Added comprehensive GitHub Copilot instructions for repository coding standards |
.github/agents/*.agent.md |
Added four agent configuration files for task delegation (triage, PHP dev, MySQL/MariaDB, code quality) |
lib/mactrack_enterasys.php |
Applied code style fixes: comment syntax, array syntax, string concatenation, and increment operators |
lib/index.php, index.php, images/index.php |
Added blank line after opening PHP tag, removed trailing blank line |
Net/DNS2/**/*.php |
Applied consistent code style fixes across all DNS2 RR classes and core files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…actrack into php_cs_fixer
Use the proper config file this time
Correct formatting and improve clarity in the MySQL and MariaDB agent documentation.
Removed unnecessary blank lines in the PHP developer agent documentation.
Member
|
Closing as the PSR was done by Copilot and not php-cs-fixer. Copilot does not follow Cacti PSR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces four new custom agent configuration files to the
.github/agentsdirectory. Each file defines a specialized agent with clear roles, tools, instructions, and routing logic to improve task delegation and support for code quality, PHP development, MySQL/MariaDB database management, and triage. The most important changes are grouped below by theme.Agent Definitions and Capabilities:
.github/agents/code-quality.agent.mdto define a Code Quality Specialist agent focused on code review, refactoring, testing, documentation, performance optimization, security, CI/CD, and code metrics for a LAMP stack and JavaScript frontend..github/agents/php-developer.agent.mdto define a PHP Developer agent specializing in PHP code development, debugging, optimization, testing, documentation, and security, with an emphasis on PSR-12 standards and modern PHP versions..github/agents/mysql-mariadb.agent.mdto define a MySQL/MariaDB Database Administrator agent for database management, query optimization, troubleshooting, backup/recovery, security, upgrades, monitoring, and scripting, including references to Cacti DB functions and documentation.Task Delegation and Routing Logic:
.github/agents/triage_agent.md.agent.mdto define a Triage Agent responsible for evaluating user requests, delegating tasks to specialized agents, monitoring progress, compiling results, and reporting back to the user. The file includes explicit routing rules, a sample rule set, decision algorithms, delegation payload templates, and logging/testing guidelines to ensure deterministic and auditable agent selection.