Skip to content

Php cs fixer updates + CI#278

Closed
bmfmancini wants to merge 20 commits intoCacti:developfrom
bmfmancini:php_cs_fixer
Closed

Php cs fixer updates + CI#278
bmfmancini wants to merge 20 commits intoCacti:developfrom
bmfmancini:php_cs_fixer

Conversation

@bmfmancini
Copy link
Member

This pull request introduces four new custom agent configuration files to the .github/agents directory. Each file defines a specialized agent with clear roles, tools, instructions, and routing logic to improve task delegation and support for code quality, PHP development, MySQL/MariaDB database management, and triage. The most important changes are grouped below by theme.

Agent Definitions and Capabilities:

  • Added .github/agents/code-quality.agent.md to define a Code Quality Specialist agent focused on code review, refactoring, testing, documentation, performance optimization, security, CI/CD, and code metrics for a LAMP stack and JavaScript frontend.
  • Added .github/agents/php-developer.agent.md to define a PHP Developer agent specializing in PHP code development, debugging, optimization, testing, documentation, and security, with an emphasis on PSR-12 standards and modern PHP versions.
  • Added .github/agents/mysql-mariadb.agent.md to define a MySQL/MariaDB Database Administrator agent for database management, query optimization, troubleshooting, backup/recovery, security, upgrades, monitoring, and scripting, including references to Cacti DB functions and documentation.

Task Delegation and Routing Logic:

  • Added .github/agents/triage_agent.md.agent.md to define a Triage Agent responsible for evaluating user requests, delegating tasks to specialized agents, monitoring progress, compiling results, and reporting back to the user. The file includes explicit routing rules, a sample rule set, decision algorithms, delegation payload templates, and logging/testing guidelines to ensure deterministic and auditable agent selection.

bmfmancini and others added 10 commits February 13, 2026 19:57
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 14, 2026 01:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies PHP-CS-Fixer code style improvements to standardize code formatting across the repository. The changes focus on modernizing comment styles, array syntax, and string concatenation patterns while maintaining PHP 8.1+ compatibility.

Changes:

  • Converted C-style block comments to single-line comments
  • Modernized array syntax from array() to []
  • Standardized string concatenation spacing
  • Updated PHPDoc formatting and improved documentation style

Reviewed changes

Copilot reviewed 104 out of 148 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.php-cs-fixer.dist.php Added PHP-CS-Fixer configuration file with PSR and PhpCsFixer rulesets
composer.json Added composer file with php-cs-fixer as dev dependency
.github/copilot-instructions.md Added comprehensive GitHub Copilot instructions for repository coding standards
.github/agents/*.agent.md Added four agent configuration files for task delegation (triage, PHP dev, MySQL/MariaDB, code quality)
lib/mactrack_enterasys.php Applied code style fixes: comment syntax, array syntax, string concatenation, and increment operators
lib/index.php, index.php, images/index.php Added blank line after opening PHP tag, removed trailing blank line
Net/DNS2/**/*.php Applied consistent code style fixes across all DNS2 RR classes and core files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bmfmancini bmfmancini changed the title Php cs fixer updates Php cs fixer updates + CI Feb 14, 2026
Correct formatting and improve clarity in the MySQL and MariaDB agent documentation.
Removed unnecessary blank lines in the PHP developer agent documentation.
@TheWitness
Copy link
Member

Closing as the PSR was done by Copilot and not php-cs-fixer. Copilot does not follow Cacti PSR.

@TheWitness TheWitness closed this Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants