Skip to content

fix: Attempt to keep the weathermap basepath the weathermap directory#229

Merged
TheWitness merged 3 commits into
developfrom
weathermap-basepath
May 18, 2026
Merged

fix: Attempt to keep the weathermap basepath the weathermap directory#229
TheWitness merged 3 commits into
developfrom
weathermap-basepath

Conversation

@TheWitness
Copy link
Copy Markdown
Member

For some reason, after some timeout issues weathermap changed behavior to where the base-path was no longer set properly causing errors finding and loading Maps.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes chdir('../../') calls from plugin entry scripts and changes include paths to be relative, keeping the working directory at the weathermap plugin location so subsequent $config['base_path']-based includes resolve properly.

Changes:

  • Drop chdir('../../') in four plugin entry scripts and use ../../include/... relative paths instead.
  • Add CHANGELOG entry documenting the fix.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
weathermap-cacti-rebuild.php Replace chdir + relative include with ../../include/cli_check.php.
weathermap-cacti-plugin.php Replace chdir + relative include with ../../include/auth.php.
weathermap-cacti-plugin-mgmt.php Replace chdir + relative include with ../../include/auth.php.
weathermap-cacti-plugin-editor.php Replace chdir + relative include with ../../include/auth.php.
CHANGELOG.md Document the basepath fix.

@TheWitness TheWitness merged commit f3be808 into develop May 18, 2026
4 checks passed
@TheWitness TheWitness deleted the weathermap-basepath branch May 18, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants