fix: correct config keys and hardcoded threshold in OneTimeLoginLinkB…#1178
Merged
steinkel merged 1 commit into16.next-cake5from Apr 12, 2026
Merged
fix: correct config keys and hardcoded threshold in OneTimeLoginLinkB…#1178steinkel merged 1 commit into16.next-cake5from
steinkel merged 1 commit into16.next-cake5from
Conversation
…ehavior - Read threshold from OneTimeLogin.thresholdTimeout config (was hardcoded to 10s) - Read token lifetime from OneTimeLogin.tokenLifeTime (was wrongly prefixed with Auth.)
There was a problem hiding this comment.
Pull request overview
Fixes One-Time Login (Magic Link) configuration lookups so the behavior uses the intended config keys and no longer relies on a hardcoded resend threshold.
Changes:
- Read the resend threshold from
OneTimeLogin.thresholdTimeout(previously hardcoded to 10 seconds). - Read token lifetime from
OneTimeLogin.tokenLifeTime(previously looked up under the incorrectAuth.prefix). - Update the corresponding unit test config key to match the corrected behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Model/Behavior/OneTimeLoginLinkBehavior.php |
Uses OneTimeLogin.thresholdTimeout for resend throttling and fixes token lifetime config key to OneTimeLogin.tokenLifeTime. |
tests/TestCase/Model/Behavior/OneTimeLoginLinkBehaviorTest.php |
Updates test configuration to use the corrected OneTimeLogin.tokenLifeTime key. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ehavior