FIREFLY-1744: Fix ADQL color mode bug in Job Monitor dialog #1902
+32
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1744
DialogRootContaineris essentially a separate root (from the mainFireflyRoot)AppConfigDrawerandDialogRootContainertake care of this, forcing a re-render of the dialog on theme changeuseColorMode()in CssStrThemeWrapper would still not give the correct theme for the dialog (because dialogs are rendered in a separate React root with their own JoyCssVarsProvider)Eventually, this PR could be made redundant if dialogs were not in a separate React Tree. We plan on discussing this change January 27-28.
Testing:
Firefly: https://fireflydev.ipac.caltech.edu/firefly-1744-adql-toggle-bug/firefly