Skip to content

Conversation

@robyww
Copy link
Contributor

@robyww robyww commented Jan 23, 2026

Firefly-1931: asdf file alpha support

  • alpha - only data under roman node, only uses roman layout
  • supports images and tables created by astropy

Reviewer notes.

  • All of the work is done in ASDFUtil.java, the other file have only have small change to recognize the ASDF files.
  • Strategy
    • Images: convert the ASDF image data to a FITS file
      • this happens at the same place we deal with compressed files.
    • Tables: read directly from the ASDF files

Testing

@robyww robyww added this to the 2026.1 milestone Jan 23, 2026
@robyww robyww self-assigned this Jan 23, 2026
@robyww robyww added Image FITS images Table Changes to table or table model labels Jan 23, 2026
@robyww robyww force-pushed the FIREFLY-1931-asdf branch from b1c8573 to 586bcd7 Compare January 23, 2026 18:36
  - alpha - only data under "roman" node
  - uses roman layout
  - support images
  - support tables
@robyww robyww force-pushed the FIREFLY-1931-asdf branch from 586bcd7 to bce1dde Compare January 23, 2026 21:36
@robyww robyww requested a review from ejoliet January 23, 2026 21:53
@ejoliet
Copy link
Contributor

ejoliet commented Jan 23, 2026

Exciting to see this and test it.
Before i do, do you know the versions of ASDF, Roman data-models and RAD you are supporting?
https://github.com/spacetelescope/roman_datamodels

Thanks!

@robyww robyww marked this pull request as ready for review January 23, 2026 23:20
@robyww
Copy link
Contributor Author

robyww commented Jan 24, 2026

@ejoliet I can only tell you what is in the asdf file.

Here is the yaml part of one of the asdf files we are using. I see so many different versions in it!

asdf-header.yaml.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Image FITS images Table Changes to table or table model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants