Move booster pics to forge-extras#10584
Conversation
|
@tehdiplomat downloads.cardforge.org doesn't exist anymore. Should we move all of the booster stuff to forge-extras? |
|
Yea it would be nice to move them to forge-extras. |
|
@Eradev do you happen to have the old images for boosters, fatpacks etc.? |
|
I'm pretty sure I have most of the boosters. Not sure about fat packs. I'll have to check at home. |
|
I have a bunch of stuff old and new, if you tell me where to send them I can send the full package |
If you make a PR here I will approve: https://github.com/Card-Forge/forge-extras/tree/main/images Edit: Or you should have merge access |
|
Yeah, I can merge there no prob, the only issue is, the package is rather rough, someone would need to give it a once-over and maybe sort the unneeded stuff or replace some of the things that may look odd :/ I mean, it was basically collected from a lot of locations and may have varying quality to it, but it's the only collection I'm aware of that has all the booster art prepared for the latest sets, achievements, etc. :/ What do we do with it all? I can drop it to a cloud storage folder and we can take a look and sort through it maybe? |
|
Dumped what I had in Card-Forge/forge-extras#27 |
|
|
||
| for (String line : boosterFileContent) { | ||
| if (line.startsWith(filename)) { | ||
| downloadUrls.add(ForgeConstants.GITHUB_ASSETS_BASE + "/images/boosters/" + filename); |
There was a problem hiding this comment.
I'm not sure i'm a huge fan of removing the option for linking out to a different site if we have a full URL. Maybe if its just the filename we prepend our URL, otherwise we use the old logic?
There was a problem hiding this comment.
Is it needed to have some images hosted on a different server if the collaborators can simply add them in forge-extras though?
There was a problem hiding this comment.
I don't think we can start hosting every users custom content for them
5 participants
No description provided.