Selective Obliteration: AI chooses the most prominent color#10605
Open
kojotak wants to merge 6 commits intoCard-Forge:masterfrom
Open
Selective Obliteration: AI chooses the most prominent color#10605kojotak wants to merge 6 commits intoCard-Forge:masterfrom
kojotak wants to merge 6 commits intoCard-Forge:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #10552
problem
Selective Obliterationis aRepeatEachability choosing a color withThe
ComputerUtilCard#chooseColor()as-is incorrectly assumes, that the activatingPlayer is always AI (computer), so it searches the wrong player's permanents, finds nothing prominent and fallbacks to white.fix
There is
Harsh Mercy- similar card choosing creature type withMostProminentInComputerDeck. This one works, becauseComputerUtil#chooseSomeTypehas the selecting player as its first parameter.test