Skip to content

Fix #9959: fixed AI behaviour concerning the card Champions of Tyr#10611

Open
PedroCalhau wants to merge 1 commit intoCard-Forge:masterfrom
PedroCalhau:patch_fix
Open

Fix #9959: fixed AI behaviour concerning the card Champions of Tyr#10611
PedroCalhau wants to merge 1 commit intoCard-Forge:masterfrom
PedroCalhau:patch_fix

Conversation

@PedroCalhau
Copy link
Copy Markdown

The Ai would refuse to cast the Champions of Tyr card because it's behaviour wasn't defined in the card's script.

Added AI logic to the Champions of Tyr card script to ensure the AI can evaluate and cast the card appropriately.

Introduced new test cases to validate the AI's decision-making in various scenarios, including resource availability, card prioritization, and threat assessment.

… of Tyr

Added Ai logic to the card script, no specific heuristics were added as
that didn't seem necessary.
@Jetz72
Copy link
Copy Markdown
Contributor

Jetz72 commented May 5, 2026

I struggle to follow how adding AILogic$ Always onto several of the card's abilities can simultaneously solve an issue where the card is never cast by the AI, while also ensuring the AI can evaluate the card and play it only in an appropriate circumstance. The card doesn't seem complicated enough that it should need any hints directing the AI how to use it. Wonder what the root of the original issue is.

@Jetz72 Jetz72 requested a review from tool4ever May 5, 2026 18:03
@tool4ever
Copy link
Copy Markdown
Contributor

Thanks for contributing:
in general we avoid tests that prove nothing new (these should already work on master + don't use heuristics engine anyway)

@Jetz72
I guess because of its complex nature EffectAi bails without specific logic - that shouldn't mean Always needs to be slapped on all three of these lines though...
Tbh quite a few cards do this and the real solution would be checking if those can be refactored into some minor code detection instead (I suspect most should) :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants