Desktop menu cleanup v2 / UI Guidelines

[MostCromulent]

• Reorganize the match-screen menu under a Game / Layout / Display / Audio hierarchy. Game shrinks to core actions; a new Display menu collects the visual toggles (Targeting Arcs, Card Overlays, Stack / Group Permanents, Tokens In Separate Row, Separate Combatants From Stacks) that previously cluttered Game.

Game - how user interacts with game state

Layout - UI layout and theme

Display - in-match display options; how game state is rendered to user

• New UI Guidelines doc at docs/Development/UI-Guidelines.md capturing the desktop-vs-mobile conventions and design principles discussed on Discord. Linked from the wiki sidebar.

  • Mobile section here is drafted on assumption Add search filter to mobile Settings menu #10450 is eventually merged

• Backend menu-code cleanup:

  • Centralized stay-open menu factories in MenuUtil. Checkbox/radio menu items that previously closed the menu after a click now use MenuUtil.createStayOpenCheckBox / createStayOpenRadioButton (and skinned variants), with the shared mouse-event interception in one private helper. Drops duplicate private factories that lived in LayoutMenu. Theme-skin selection is the one intentional exception (still closes the menu on click).
  • Added MenuUtil.withMatchUI(Consumer<VMatchUI>) to consolidate the Singletons.getControl().getCurrentScreen().getView()-cast-to-VMatchUI pattern. Replaces 5 cast sites in LayoutMenu and 1 in ForgeMenu.
  • Removed the always-false showIcons constant and the conditional setIcon calls it gated in GameMenu, DisplayMenu, and LayoutMenu. Also dropped the dock-style icon plumbing it supported in DisplayMenu (the menuIcon tracking, the parent-submenu icon update, and the setTargetingArcMenuIcon helper). WorkshopFileMenu and DeckFileMenu still use a live showIcons setter and are untouched.
  • Dropped the LayoutMenu.currentScreen instance field — it's now a local in getMenu().
  • Hide Theme and Sound/Music Set submenus when only one option is installed, instead of showing a single-option submenu.

🤖 Generated with Claude Code