Added flying animation for flying creatures#9421
Open
jtomse wants to merge 2 commits intoCard-Forge:masterfrom
Open
Added flying animation for flying creatures#9421jtomse wants to merge 2 commits intoCard-Forge:masterfrom
jtomse wants to merge 2 commits intoCard-Forge:masterfrom
Conversation
tehdiplomat
reviewed
Jan 10, 2026
Contributor
|
I tested this out and the floating animation seemed to cause distortion on the card image and text of the flyer, in a way I thought was a bit distracting. Not sure if this bothers anyone else. I guess one answer is you can always turn it off if you don't like it. |
Author
|
Hmm..I don't get any distortion on my end - it's crystal clear. Maybe due to monitor refresh rate? Mine is set to 165 Hz. Is yours different? The animation plays at 20 FPS, so if others are getting distortion or tearing I could increase it. Just trying to keep resource usage as low as possible. Maybe I went too low. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactored version of my previous attempt. Adds my second favorite QoL feature from other MTG implementations (DOTP, Magic Arena, etc.) - a subtle floating animation for flying creatures. The option is toggled off by default. Added a descriptive toggle in the in-game Preferences menu (towards the bottom of the "Graphics Options" section) to allow users to activate this new functionality as desired. Not only makes parsing game-states with many creatures easier, it looks cool too!
Please let me know if this attempt looks better - thanks!