Add workflow_status to Create payload messages#5
Open
dnewh wants to merge 2 commits intoryanlassigbanks-purchase-order-rfcfrom
Open
Add workflow_status to Create payload messages#5dnewh wants to merge 2 commits intoryanlassigbanks-purchase-order-rfcfrom
workflow_status to Create payload messages#5dnewh wants to merge 2 commits intoryanlassigbanks-purchase-order-rfcfrom
Conversation
dnewh
requested review from
agunde406,
davececchi,
jsmitchell,
peterschwarz and
vaporos
as code owners
dnewh
force-pushed
the
dnewh-update-version-protos
branch
from
2acf7ed to
5c11846
Compare
This adds a field `workflow_status` to the `CreatePurchaseOrderPayload` and `CreateVersionPayload` messages. This brings those messages in line with their `Update*` counterparts. Signed-off-by: Davey Newhall <newhall@bitwise.io>
This adds the `workflow_type` field to `PurchaseOrder`'s state representation. This will mark which workflow the PurchaseOrder is/was going through. Signed-off-by: Davey Newhall <newhall@bitwise.io>
dnewh
force-pushed
the
dnewh-update-version-protos
branch
from
5c11846 to
d448125
Compare
vaporos
approved these changes
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a field
workflow_statusto theCreatePurchaseOrderPayloadand
CreateVersionPayloadmessages. This brings those messages in linewith their
Update*counterparts.Signed-off-by: Davey Newhall newhall@bitwise.io