Skip to content

IDE-290 Test FormulaEditorComputeDialogUserDefinedBrickInputTest.userDefinedBrickInputTest fails locally and on Jenkins#5105

Merged
wslany merged 4 commits intoCatrobat:developfrom
doppem15:IDE-290
Apr 26, 2026
Merged

IDE-290 Test FormulaEditorComputeDialogUserDefinedBrickInputTest.userDefinedBrickInputTest fails locally and on Jenkins#5105
wslany merged 4 commits intoCatrobat:developfrom
doppem15:IDE-290

Conversation

@doppem15
Copy link
Copy Markdown
Contributor

@doppem15 doppem15 commented Aug 11, 2025

To make the test work, I added an additional parameter (variable) to the FormulaEditorComputeDialogUserDefinedBrickInputTest class so that the constructor would be called correctly.

https://catrobat.atlassian.net/browse/IDE-290

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@sonarqubecloud
Copy link
Copy Markdown

@reichli reichli added the Active Member Tickets that are assigned to members that are still currently active label Dec 25, 2025
Copy link
Copy Markdown
Member

@harshsomankar123-tech harshsomankar123-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just Rebase needed

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@wslany wslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests that failed are green now.

@wslany wslany merged commit 5256191 into Catrobat:develop Apr 26, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Active Member Tickets that are assigned to members that are still currently active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants