IDE-299 Rewrite LoadProjectAIExtensionSettingsTest from End2End-test to Integration-test#5122
IDE-299 Rewrite LoadProjectAIExtensionSettingsTest from End2End-test to Integration-test#5122Kale2605 wants to merge 3 commits intoCatrobat:developfrom
Conversation
Prior: used espresso Now: save and load project and check flags (no ui)
Kale2605
force-pushed
the
load_settings_test
branch
from
35318df to
624dca8
Compare
|
reichli
added
the
Active Member
There was a problem hiding this comment.
@Kale2605 Thanks for refactoring this test! Moving from Espresso to an integration test really improves CI speed and stability.Plz see reviewed changes
| @@ -0,0 +1,56 @@ | |||
| /* | |||
| * Catroid: An on-device visual programming system for Android devices | |||
| * Copyright (C) 2010-2025 The Catrobat Team | |||
There was a problem hiding this comment.
Change Copyright Year To 2026
| projectManager.currentProject = project | ||
| projectManager.currentSprite = sprite | ||
| projectManager.currentlyEditedScene = project.defaultScene | ||
| XstreamSerializer.getInstance().saveProject(project) |
There was a problem hiding this comment.
This saveProject call is redundant. The test testSettingsBeforeAndAfterLoadProject already calls saveProject after adding the specific brick, so saving here just adds unnecessary I/O.
| private var file: File = File("") | ||
|
|
||
| @get:Rule | ||
| var baseActivityTestRule: BaseActivityTestRule<MainMenuActivity> = BaseActivityTestRule( |
There was a problem hiding this comment.
Since we are no longer launching an activity in this integration test, this baseActivityTestRule is unused and should be removed, along with its imports (e.g., MainMenuActivity and BaseActivityTestRule)
There was a problem hiding this comment.
This asset was added but is not referenced in the test code. Is this a leftover from a previous iteration? If it's not needed for the test to pass, it should be removed.
| @@ -1,3 +1,3 @@ | |||
| /* | |||
| * Catroid: An on-device visual programming system for Android devices | |||
| * Copyright (C) 2010-2025 The Catrobat Team | |||
3 participants
Rewrite LoadProjectAIExtensionSettingsTest from End2End-test to Integration-test.
https://catrobat.atlassian.net/browse/IDE-299?atlOrigin=eyJpIjoiMzJmMDE3MTFjZTJmNDgyZjhiM2M2NWYzZTdlOGFjZWYiLCJwIjoiaiJ9
LoadProjectAIExtensionSettingsTest uses ProjectManager instead of espresso navigation.
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.