Skip to content

CATROID-1596 Fix test 'importActorOrObjectTest'#5151

Open
hannesweilharter wants to merge 1 commit intoCatrobat:developfrom
hannesweilharter:CATROID-1596
Open

CATROID-1596 Fix test 'importActorOrObjectTest'#5151
hannesweilharter wants to merge 1 commit intoCatrobat:developfrom
hannesweilharter:CATROID-1596

Conversation

@hannesweilharter
Copy link
Contributor

@hannesweilharter hannesweilharter commented Feb 15, 2026

  • fix all tests of ImportLocalSpriteTest
  • new object EspressoIdlingResource wrapping an CountingIdlingResource to properly synchronize asynchronous operations during testing. This ensures waiting for all pending operations.
  • Adaptions in ProjectListFragment
  • Formatting

https://catrobat.atlassian.net/browse/CATROID-1596

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@@ -0,0 +1,40 @@
/*

Check warning

Code scanning / detekt

Detects missing final newlines Warning

File must end with a newline (\n)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a newline at the end of the file please.

@reichli reichli added the Active Member Tickets that are assigned to members that are still currently active label Feb 20, 2026
Copy link
Contributor

@Frajhamster Frajhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash all commits into one please!

@@ -0,0 +1,40 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a newline at the end of the file please.

Copy link
Contributor

@Frajhamster Frajhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Active Member Tickets that are assigned to members that are still currently active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants