PAINTROID-XXX Fix disabled color not applied to ActionButton#148
Open
jShubh-AD wants to merge 1 commit intoCatrobat:developfrom
Open
PAINTROID-XXX Fix disabled color not applied to ActionButton#148jShubh-AD wants to merge 1 commit intoCatrobat:developfrom
jShubh-AD wants to merge 1 commit intoCatrobat:developfrom
Conversation
Author
|
Hi Mentors, 👋 I would appreciate any guidance on the preferred Jira workflow, so I can follow it correctly in future contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Jira: PAINTROID-XXX
Jira link: N/A
Refactorings and Bug Fixes
Fix disabled color not applied to ActionButton when onPressed is null due to incorrect cascade usage on immutable Color.
Checklist
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.
Demo
Current behavior
current_flow.mp4
Expected outcome
expected_outcome.mp4