Skip to content

PAINTROID-XXX Fix disabled color not applied to ActionButton#148

Open
jShubh-AD wants to merge 1 commit intoCatrobat:developfrom
jShubh-AD:Fix/Disable-icon-color
Open

PAINTROID-XXX Fix disabled color not applied to ActionButton#148
jShubh-AD wants to merge 1 commit intoCatrobat:developfrom
jShubh-AD:Fix/Disable-icon-color

Conversation

@jShubh-AD
Copy link

Related Jira: PAINTROID-XXX
Jira link: N/A

Refactorings and Bug Fixes

Fix disabled color not applied to ActionButton when onPressed is null due to incorrect cascade usage on immutable Color.

Checklist

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Add the link to the ticket in Jira in the description of the PR
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines (Wiki)
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Add new information to the Wiki

Demo

  • Current behavior

  • current_flow.mp4
  • Expected outcome

  • expected_outcome.mp4

@jShubh-AD
Copy link
Author

Hi Mentors, 👋
I wasn’t able to confirm whether this issue already exists in Jira, and I’m also unsure if my inability to create or comment on a ticket is due to permission restrictions. Therefore, I submitted this fix directly via PR.

I would appreciate any guidance on the preferred Jira workflow, so I can follow it correctly in future contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant